Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some support for WPT tests in an Android emulator through WebDriver #21213
Conversation
Not setting one of them in a SetTimeouts requests should not remove it. This fixes a panicking `unwrap()`.
When sending a webdriver load URL command soon enough after starting Servo, that command could time out with a logged warning: ``` constellation: Webdriver load for closed browsing context (0,2). ``` When `closed` in this case really meant not opened yet.
…ding
```
Traceback (most recent call last):
File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 90, in run
rv = commands[command](*args)
File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 110, in wait
self.executor.wait()
File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/base.py", line 209, in wait
self.protocol.base.wait()
AttributeError: 'ServoWebDriverProtocol' object has no attribute 'base'
```
``` 0:27.48 pid:4157 Traceback (most recent call last): 0:27.48 pid:4157 File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 212, in <module> 0:27.48 pid:4157 sys.exit(main(*sys.argv[1:])) 0:27.48 pid:4157 File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 72, in main 0:27.48 pid:4157 forward_webdriver(adb, args) 0:27.48 pid:4157 File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 163, in forward_webdriver 0:27.48 pid:4157 ports = [int(part) for part in split if part] 0:27.48 pid:4157 ValueError: invalid literal for int() with base 10: 'None' ```
highfive
commented
Jul 19, 2018
|
Heads up! This PR modifies the following files:
|
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#74. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2018
Add some support for WPT tests in an Android emulator through WebDriver This succeeds on my machine: `./mach test-wpt --product servodriver --binary etc/run_in_headless_android_emulator.py --binary-arg servo-x86 --binary-arg target/i686-linux-android/release/servo.apk /_mozilla/mozilla/DOMParser.html` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21213) <!-- Reviewable:end -->
|
|
|
This did not break any existing test harness stuff that is executed on CI; all platforms passed. |
This makes `/_mozilla/mozilla/webgl/context_creation_error.html` pass, for example. ``` ./ mach test-wpt --product servodriver \ --binary etc/run_in_headless_android_emulator.py \ --binary-arg servo-x86 \ --binary-arg target/i686-linux-android/release/servo.apk \ /_mozilla/mozilla/webgl/context_creation_error.html ```
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#74. |
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#74. |
|
|
|
@bors-servo retry |
|
|
|
|
This was referenced Jul 21, 2018
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
…ding Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
```
Traceback (most recent call last):
File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 90, in run
rv = commands[command](*args)
File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 110, in wait
self.executor.wait()
File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/base.py", line 209, in wait
self.protocol.base.wait()
AttributeError: 'ServoWebDriverProtocol' object has no attribute 'base'
```
Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
``` 0:27.48 pid:4157 Traceback (most recent call last): 0:27.48 pid:4157 File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 212, in <module> 0:27.48 pid:4157 sys.exit(main(*sys.argv[1:])) 0:27.48 pid:4157 File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 72, in main 0:27.48 pid:4157 forward_webdriver(adb, args) 0:27.48 pid:4157 File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 163, in forward_webdriver 0:27.48 pid:4157 ports = [int(part) for part in split if part] 0:27.48 pid:4157 ValueError: invalid literal for int() with base 10: 'None' ``` Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
This makes `/_mozilla/mozilla/webgl/context_creation_error.html` pass, for example. ``` ./ mach test-wpt --product servodriver \ --binary etc/run_in_headless_android_emulator.py \ --binary-arg servo-x86 \ --binary-arg target/i686-linux-android/release/servo.apk \ /_mozilla/mozilla/webgl/context_creation_error.html ``` Upstreamed from servo/servo#21213 [ci skip]
jdm
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2018
Upstreamed from servo/servo#21213 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJul 19, 2018
•
edited
This succeeds on my machine:
./mach test-wpt --product servodriver --binary etc/run_in_headless_android_emulator.py --binary-arg servo-x86 --binary-arg target/i686-linux-android/release/servo.apk /_mozilla/mozilla/DOMParser.htmlThis change is