Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some support for WPT tests in an Android emulator through WebDriver #21213

Merged
merged 15 commits into from Jul 21, 2018

Commits on Jul 19, 2018

  1. WebDriver timeout settings are not optional.

    Not setting one of them in a SetTimeouts requests should not remove it.
    This fixes a panicking `unwrap()`.
    SimonSapin committed Jul 19, 2018
  2. Fix a webdriver timeout during server start up

    When sending a webdriver load URL command soon enough after starting Servo,
    that command could time out with a logged warning:
    
    ```
    constellation: Webdriver load for closed browsing context (0,2).
    ```
    
    When `closed` in this case really meant not opened yet.
    SimonSapin committed Jul 19, 2018
  3. More Python fixes for servodriver

    ```
    Traceback (most recent call last):
      File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 90, in run
        rv = commands[command](*args)
      File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 110, in wait
        self.executor.wait()
      File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/base.py", line 209, in wait
        self.protocol.base.wait()
    AttributeError: 'ServoWebDriverProtocol' object has no attribute 'base'
    ```
    SimonSapin committed Jul 19, 2018
  4. Don’t reverse-forward port "None"

    ```
     0:27.48 pid:4157 Traceback (most recent call last):
     0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 212, in <module>
     0:27.48 pid:4157     sys.exit(main(*sys.argv[1:]))
     0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 72, in main
     0:27.48 pid:4157     forward_webdriver(adb, args)
     0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 163, in forward_webdriver
     0:27.48 pid:4157     ports = [int(part) for part in split if part]
     0:27.48 pid:4157 ValueError: invalid literal for int() with base 10: 'None'
    ```
    SimonSapin committed Jul 19, 2018

Commits on Jul 20, 2018

  1. servodriver: fix setting preferences

    This makes `/_mozilla/mozilla/webgl/context_creation_error.html` pass,
    for example.
    
    ```
    ./ mach test-wpt --product servodriver \
      --binary etc/run_in_headless_android_emulator.py \
      --binary-arg servo-x86 \
      --binary-arg target/i686-linux-android/release/servo.apk \
      /_mozilla/mozilla/webgl/context_creation_error.html
    ```
    SimonSapin committed Jul 20, 2018
  2. Add ./mach test-wpt-android

    SimonSapin committed Jul 20, 2018
  3. servodriver: increase browser’s init_timeout

    SimonSapin committed Jul 20, 2018
You can’t perform that action at this time.