Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some support for WPT tests in an Android emulator through WebDriver #21213

Merged
merged 15 commits into from Jul 21, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Add --binary-arg support in ./mach test-wpt --product servodriver

  • Loading branch information
SimonSapin committed Jul 19, 2018
commit c05d30d116345f5a3f8a25c2aa197f91ebecd844
@@ -37,6 +37,7 @@ def check_args(**kwargs):
def browser_kwargs(test_type, run_info_data, **kwargs):
return {
"binary": kwargs["binary"],
"binary_args": kwargs["binary_args"],
"debug_info": kwargs["debug_info"],
"server_config": kwargs["config"],
"user_stylesheets": kwargs.get("user_stylesheets"),
@@ -74,9 +75,10 @@ class ServoWebDriverBrowser(Browser):
used_ports = set()

def __init__(self, logger, binary, debug_info=None, webdriver_host="127.0.0.1",
server_config=None, user_stylesheets=None):
server_config=None, binary_args=None, user_stylesheets=None):
Browser.__init__(self, logger)
self.binary = binary
self.binary_args = binary_args or []
self.webdriver_host = webdriver_host
self.webdriver_port = None
self.proc = None
@@ -95,7 +97,7 @@ def start(self, **kwargs):

debug_args, command = browser_command(
self.binary,
[
self.binary_args + [
"--hard-fail",
"--webdriver", str(self.webdriver_port),
"about:blank",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.