Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some support for WPT tests in an Android emulator through WebDriver #21213

Merged
merged 15 commits into from Jul 21, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Don’t reverse-forward port "None"

```
 0:27.48 pid:4157 Traceback (most recent call last):
 0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 212, in <module>
 0:27.48 pid:4157     sys.exit(main(*sys.argv[1:]))
 0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 72, in main
 0:27.48 pid:4157     forward_webdriver(adb, args)
 0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 163, in forward_webdriver
 0:27.48 pid:4157     ports = [int(part) for part in split if part]
 0:27.48 pid:4157 ValueError: invalid literal for int() with base 10: 'None'
```
  • Loading branch information
SimonSapin committed Jul 19, 2018
commit cdd64604cf0c3f837f2b20faa786d6d2595c22d3
@@ -99,6 +99,7 @@ def start(self, **kwargs):
str(port)
for _protocol, ports in self.server_ports.items()
for port in ports
if port
)

debug_args, command = browser_command(
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.