Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt the constellation #21225

Merged
merged 1 commit into from Jul 23, 2018
Merged

Rustfmt the constellation #21225

merged 1 commit into from Jul 23, 2018

Conversation

@cbrewster
Copy link
Member

cbrewster commented Jul 21, 2018 •
edited by SimonSapin

Yay for consistency!

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because just formatting things

This change is Reviewable
@cbrewster
Rustfmt the constellation
Loading status checks…
a2064ce
@highfive
Copy link

highfive commented Jul 21, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/event_loop.rs, components/constellation/session_history.rs, components/constellation/constellation.rs, components/constellation/network_listener.rs and 4 more
  • @paulrouget: components/constellation/pipeline.rs, components/constellation/event_loop.rs, components/constellation/session_history.rs, components/constellation/constellation.rs, components/constellation/network_listener.rs and 4 more
@paulrouget
Copy link
Contributor

paulrouget commented Jul 23, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

📌 Commit a2064ce has been approved by paulrouget
@highfive highfive assigned paulrouget and unassigned jdm Jul 23, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

⌛ Testing commit a2064ce with merge c71fafa...
bors-servo added a commit that referenced this pull request Jul 23, 2018
@bors-servo
Auto merge of #21225 - cbrewster:rustfmt_constellation, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c71fafa 
Rustfmt the constellation

<!-- Please describe your changes on the following line: -->
Yay for consistency!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because just formatting things

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21225)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Jul 23, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Jul 23, 2018

@bors-servo retry

  • builder was full
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paulrouget
Pushing c71fafa to master...
@bors-servo bors-servo merged commit a2064ce into servo:master Jul 23, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 23, 2018
Merged
0 of 6 tasks complete
@jdm jdm mentioned this pull request Aug 9, 2018
Closed
53 of 53 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@cbrewster @highfive @paulrouget @bors-servo @jdm
You can’t perform that action at this time.