Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: A couple mutation observer fixes. #21236

Merged
merged 3 commits into from Jul 23, 2018
Merged

script: A couple mutation observer fixes. #21236

merged 3 commits into from Jul 23, 2018

Conversation

@emilio
Copy link
Member

emilio commented Jul 23, 2018 •
edited by SimonSapin

I felt like doing Servo stuff while trying to catch Gecko intermittents :)

This fixes most of #21233. I haven't dug into the other test.

This change is Reviewable
emilio added 3 commits Jul 23, 2018
@emilio
script: Queue a mutation record from CharacterData::append_data.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
e4f978e
@emilio
script: Avoid useless string clones in mutation observer stuff.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
0736290
@emilio
script: Fix the logic for mutation observer attributes.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
39e647d
@highfive
Copy link

highfive commented Jul 23, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/characterdata.rs, components/script/dom/mutationobserver.rs
  • @KiChjang: components/script/dom/characterdata.rs, components/script/dom/mutationobserver.rs
@emilio emilio requested review from nox and jdm Jul 23, 2018
@jdm
Copy link
Member

jdm commented Jul 23, 2018

@bors-servo r+
Thanks for fixing those!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

📌 Commit 39e647d has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Jul 23, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

⌛ Testing commit 39e647d with merge 41f9f85...
bors-servo added a commit that referenced this pull request Jul 23, 2018
@bors-servo
Auto merge of #21236 - emilio:mutation-observer, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41f9f85 
script: A couple mutation observer fixes.

I felt like doing Servo stuff while trying to catch Gecko intermittents :)

This fixes most of #21233. I haven't dug into the other test.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21236)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 41f9f85 to master...
@bors-servo bors-servo merged commit 39e647d into servo:master Jul 23, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Jul 24, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@nox nox

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.