Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check for GL object ownership (fixes #21133) #21240

Merged
merged 2 commits into from Jul 24, 2018
Merged

Properly check for GL object ownership (fixes #21133) #21240

merged 2 commits into from Jul 24, 2018

Conversation

@nox
Copy link
Member

nox commented Jul 24, 2018 •
edited by SimonSapin

This change is Reviewable
nox added 2 commits Jul 24, 2018
@nox
Store a reference to the WebGLRenderingContext in WebGLObject
661e258
@nox
Properly check for GL object ownership (fixes #21133)
Loading status checks…
3179ed5
@highfive
Copy link

highfive commented Jul 24, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglprogram.rs, components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs and 5 more
  • @KiChjang: components/script/dom/webglprogram.rs, components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs and 5 more
@jdm
Copy link
Member

jdm commented Jul 24, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

📌 Commit 3179ed5 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Jul 24, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

⌛ Testing commit 3179ed5 with merge 65df9cb...
bors-servo added a commit that referenced this pull request Jul 24, 2018
@bors-servo
Auto merge of #21240 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
65df9cb 
Properly check for GL object ownership (fixes #21133)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21240)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

💔 Test failed - mac-rel-css2
@CYBAI
Copy link
Collaborator

CYBAI commented Jul 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

💔 Test failed - mac-rel-css2
@jdm
Copy link
Member

jdm commented Jul 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 65df9cb to master...
@bors-servo bors-servo merged commit 3179ed5 into master Jul 24, 2018
3 of 5 checks passed
3 of 5 checks passed
Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @jdm @bors-servo @CYBAI @asajeffrey
You can’t perform that action at this time.