New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check for GL object ownership (fixes #21133) #21240

Merged
merged 2 commits into from Jul 24, 2018

Conversation

Projects
None yet
6 participants
@nox
Member

nox commented Jul 24, 2018

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Jul 24, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglprogram.rs, components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs and 5 more
  • @KiChjang: components/script/dom/webglprogram.rs, components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglshader.rs and 5 more
@jdm

This comment has been minimized.

Member

jdm commented Jul 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

📌 Commit 3179ed5 has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey Jul 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

⌛️ Testing commit 3179ed5 with merge 65df9cb...

bors-servo added a commit that referenced this pull request Jul 24, 2018

Auto merge of #21240 - servo:webgl, r=jdm
Properly check for GL object ownership (fixes #21133)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21240)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

💔 Test failed - mac-rel-css2

@CYBAI

This comment has been minimized.

Collaborator

CYBAI commented Jul 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

💔 Test failed - mac-rel-css2

@jdm

This comment has been minimized.

Member

jdm commented Jul 24, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 24, 2018

@bors-servo bors-servo merged commit 3179ed5 into master Jul 24, 2018

3 of 5 checks passed

Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment