Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache which capabilities are enabled in the context (fixes #20534) #21246

Merged
merged 1 commit into from Jul 25, 2018
Merged

Cache which capabilities are enabled in the context (fixes #20534) #21246

merged 1 commit into from Jul 25, 2018

Conversation

@nox
Copy link
Member

nox commented Jul 25, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Jul 25, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented Jul 25, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jul 25, 2018

r? @avadacatavra
@highfive highfive assigned avadacatavra and unassigned mbrubeck Jul 25, 2018
@emilio
emilio approved these changes Jul 25, 2018
View changes
Copy link
Member

emilio left a comment

LGTM
components/script/dom/webglrenderingcontext.rs Outdated
@@ -2192,15 +2185,15 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3
// FIXME: https://github.com/servo/servo/issues/20534

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Jul 25, 2018

Member

Remove the FIXME?
@emilio
Copy link
Member

emilio commented Jul 25, 2018

Oh, I hadn't seen the comment above, and @nox asked me to review on IRC. Sorry for stealing the review :(
@nox
Cache which capabilities are enabled in the context (fixes #20534)
Loading status checks…
5a9ad01 
This is needed for #20555.
@nox nox force-pushed the webgl branch from b9038d6 to 5a9ad01 Jul 25, 2018
@nox
Copy link
Member Author

nox commented Jul 25, 2018

@bors-servo r=emilio

I fixed the FIXMEs.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2018

📌 Commit 5a9ad01 has been approved by emilio
@highfive highfive assigned emilio and unassigned avadacatavra Jul 25, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2018

⌛ Testing commit 5a9ad01 with merge 4c5a7ea...
bors-servo added a commit that referenced this pull request Jul 25, 2018
@bors-servo
Auto merge of #21246 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4c5a7ea 
Cache which capabilities are enabled in the context (fixes #20534)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21246)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 4c5a7ea to master...
@bors-servo bors-servo merged commit 5a9ad01 into master Jul 25, 2018
4 of 5 checks passed
4 of 5 checks passed
Taskcluster (pull_request) TaskGroup: Pending (for pull_request.synchronize)
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the webgl branch Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@nox @highfive @jdm @emilio @bors-servo @mbrubeck @avadacatavra
You can’t perform that action at this time.