Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow webgl tests using unit test harness to run to completion. #21249
Conversation
| ("timeout.patch", None) | ||
| ] | ||
| # Patches for conformance tests 2.0.x | ||
| PATCHES_2X = [ | ||
| ("js-test-pre2.patch", "js/js-test-pre.js"), | ||
| ("unit.patch", "conformance/more/unit.js") | ||
| ("unit2.patch", "conformance/more/unit.js") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdm
Jul 26, 2018
Author
Member
I don't know if that would affect the line numbers of unit.patch. This seemed easier.
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 26, 2018
Allow webgl tests using unit test harness to run to completion. This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13662 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21249) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2018
Allow webgl tests using unit test harness to run to completion. This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13662 fix #10656 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21249) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2018
Allow webgl tests using unit test harness to run to completion. This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13662 fix #10656 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21249) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 25, 2018
•
edited
This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is