Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the packed_simd crate instead of std::simd #21272

Merged
merged 1 commit into from Jul 29, 2018
Merged

Use the packed_simd crate instead of std::simd #21272

merged 1 commit into from Jul 29, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 27, 2018 •
edited

std::simd was removed in rust-lang/rust#52535.
https://crates.io/crates/packed_simd is in the rust-lang-nursery org.

This change is Reviewable
@highfive
Copy link

highfive commented Jul 27, 2018

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@avadacatavra
Copy link
Contributor

avadacatavra commented Jul 27, 2018

@bors-servo r+
@highfive highfive assigned avadacatavra and unassigned Manishearth Jul 27, 2018
@jdm
Copy link
Member

jdm commented Jul 27, 2018 

Checking files for tidiness...
./components/gfx/text/glyph.rs:11: use statement is not in alphabetical order
	expected: std::cmp::{Ordering, PartialOrd}
	found: packed_simd::u32x4
Running the dependency licensing lint...
@SimonSapin
Use the packed_simd crate instead of std::simd
Loading status checks…
1c0941f 
`std::simd` was removed in rust-lang/rust#52535.
https://crates.io/crates/packed_simd is in the rust-lang-nursery org.
@SimonSapin SimonSapin force-pushed the rustup branch from 6473c28 to 1c0941f Jul 27, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 27, 2018 •
edited

@bors-servo r=avadacatavra
1 similar comment
@jdm
Copy link
Member

jdm commented Jul 27, 2018

@bors-servo r=avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2018

📌 Commit 1c0941f has been approved by avadacatavra
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

⌛ Testing commit 1c0941f with merge f9db69b...
bors-servo added a commit that referenced this pull request Jul 28, 2018
@bors-servo
Auto merge of #21272 - servo:rustup, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f9db69b 
Use the packed_simd crate instead of std::simd

`std::simd` was removed in rust-lang/rust#52535.
https://crates.io/crates/packed_simd is in the rust-lang-nursery org.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21272)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented Jul 28, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

⌛ Testing commit 1c0941f with merge 7bd4dd3...
bors-servo added a commit that referenced this pull request Jul 28, 2018
@bors-servo
Auto merge of #21272 - servo:rustup, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7bd4dd3 
Use the packed_simd crate instead of std::simd

`std::simd` was removed in rust-lang/rust#52535.
https://crates.io/crates/packed_simd is in the rust-lang-nursery org.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21272)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

💔 Test failed - linux-rel-wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

⚡ Previous build results for android, android-x86, arm32, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only arm64, linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

💔 Test failed - arm64
@jdm
Copy link
Member

jdm commented Jul 28, 2018

@bors-servo retry

  • builder was full
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

⌛ Testing commit 1c0941f with merge acbd4fa...
bors-servo added a commit that referenced this pull request Jul 28, 2018
@bors-servo
Auto merge of #21272 - servo:rustup, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
acbd4fa 
Use the packed_simd crate instead of std::simd

`std::simd` was removed in rust-lang/rust#52535.
https://crates.io/crates/packed_simd is in the rust-lang-nursery org.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21272)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

💔 Test failed - arm32
@jdm
Copy link
Member

jdm commented Jul 28, 2018 •
edited

More build machine disk space woes.
@jdm
Copy link
Member

jdm commented Jul 29, 2018

@bors-servo retry

  • cleaned up the build machine
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2018

⌛ Testing commit 1c0941f with merge de48f25...
bors-servo added a commit that referenced this pull request Jul 29, 2018
@bors-servo
Auto merge of #21272 - servo:rustup, r=avadacatavra
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
de48f25 
Use the packed_simd crate instead of std::simd

`std::simd` was removed in rust-lang/rust#52535.
https://crates.io/crates/packed_simd is in the rust-lang-nursery org.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21272)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Jul 29, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Jul 29, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: avadacatavra
Pushing de48f25 to master...
@bors-servo bors-servo merged commit 1c0941f into master Jul 29, 2018
3 of 5 checks passed
3 of 5 checks passed
Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 29, 2018
Closed
@SimonSapin SimonSapin deleted the rustup branch Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avadacatavra avadacatavra

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@SimonSapin @highfive @avadacatavra @jdm @bors-servo @CYBAI @Manishearth
You can’t perform that action at this time.