Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local android toolchain for dynamic symbol check. #21275

Merged
merged 1 commit into from Jul 28, 2018
Merged

Conversation

@jdm
Copy link
Member

jdm commented Jul 27, 2018

Fixes servo/saltfs#869 and unbreaks all of the android builds.


This change is Reviewable

@highfive
Copy link

highfive commented Jul 27, 2018

Heads up! This PR modifies the following files:

@jdm
Copy link
Member Author

jdm commented Jul 27, 2018

@bors-servo r+ p=100

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2018

📌 Commit 2fda6bf has been approved by jdm

@highfive highfive assigned jdm and unassigned gw3583 Jul 27, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

Testing commit 2fda6bf with merge 5f0b715...

bors-servo added a commit that referenced this pull request Jul 28, 2018
Use local android toolchain for dynamic symbol check.

Fixes servo/saltfs#869 and unbreaks all of the android builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21275)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2018

@bors-servo bors-servo merged commit 2fda6bf into master Jul 28, 2018
3 of 5 checks passed
3 of 5 checks passed
Tidelift An error occured
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-24 branch Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.