Reacting to environment changes #21280

paavininanda · 2018-07-30T06:34:14Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix a subset of #11416

These changes do not require tests because they will be added when the complete responsive images is complete

This change is

highfive · 2018-07-30T06:34:18Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmlimageelement.rs
@KiChjang: components/script/dom/htmlimageelement.rs

highfive · 2018-07-30T06:34:20Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

paavininanda · 2018-07-30T06:35:06Z

r? @jdm

jdm

Good start! The general framework is here; now we need to focus on some missing details.

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

-               return
-           }
-       }
+        let area_elements = self.areas();


Let's revert the changes to this function.

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

@@ -871,6 +871,166 @@ impl HTMLImageElement {
        ScriptThread::await_stable_state(Microtask::ImageElement(task));
    }

+    /// <https://html.spec.whatwg.org/multipage/#img-environment-changes>
+    fn react_to_environment_changes(&self) {


This isn't used anywhere yet, so let's add some integration:

add a Vec<Dom<HTMLImageElement>> member to Document; this will be a list of responsive images that exist in the document

Add methods to document to register and unregister responsive images by manipulating the vector

Add method to Document that iterates over the vector and invokes react_to_environment_changes

Use the new registration APIs from HTMLImageElement's bind_to_tree and unbind_from_tree methods (when binding, if is_in_doc is true then the element should be registered, when unbinding the element should be unregistered)

call the new Document method from Window.evaluate_media_queries_and_report_changes

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+        ScriptThread::await_stable_state(Microtask::ImageElement(task));
+    }
+
+    /// Step 3-12 of https://html.spec.whatwg.org/multipage/#img-environment-changes


What about step 2?

Didn't know how to handle multipart/x-mixed-replace, couldn't find it anywhere in the already implemented code.

Step 2 is a list of condititions that should be checked, and the function should return immediately if any of them are true.

We have added checks for all conditions except multipart/x-mixed-replace. Multipart is a mime::TopLevel but how do we check for x-mixed-replace ?

The Ext Sublevel enum variant can contain any string value.

Step 2 is there at EnvironmentChangesTask

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+        let elem = self.upcast::<Element>();
+        let document = document_from_node(elem);
+        let base_url = document.base_url();
+        match self.select_image_source() {


We can skip some work here by doing:

// Steps 3-4 let (selected_source, selected_pixel_density) = match self.select_image_source() { Some(selected) => selected, None => return, };

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+        }
+
+        // Step 6
+        if let Ok(img_url) = base_url.join(&String::from(src.clone())) {


For cases where we return if an operation didn't succeed, it's more readable to do:

let img_url = match base_url.join(&src) { Ok(url) => url, Err(_) => return, };

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+                            let this = this.root();
+                            // Step 15.1
+                            if relevant_mutation {
+                                let mut _pending_request =


I believe we can use abort_request for this instead.

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+                            // Step 15.2
+                            *this.last_selected_source.borrow_mut() = Some(DOMString::from_string(new_selected_source));
+                            let mut current_request = this.current_request.borrow_mut();
+                            current_request.current_pixel_density = selected_pixel_density;


I believe this needs to use the pending request, since it will be upgraded to the current request in 15.5.

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+                            current_request.current_pixel_density = selected_pixel_density;
+
+                            // Step 15.3
+                            this.current_request.borrow_mut().state = State::CompletelyAvailable;


I think this needs to use the pending request.

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+                            // Already a part of the list of available images due to Step 14
+
+                            // Step 15.5
+                            current_request = this.pending_request.borrow_mut();


This doesn't actually overwrite the contents of current_request. We need *current_request for that.

jdm · 2018-07-30T20:29:23Z

components/script/dom/htmlimageelement.rs

+            );
+
+        }
+        return;


This return is redundant.

jdm

Closer! Once the code in document.rs is correctly registering and unregistering image elements, running the tests should produce different results. Until then, none of this new code is being executed.

jdm · 2018-08-01T22:07:44Z

components/script/dom/document.rs

+    }
+
+    pub fn register_responsive_images(&self) {
+        for image in self.responsive_images.iter() {


I don't understand what this method is attempting to do - the APIs I suggested for registering and unregistering would take an &HTMLImageElement argument and modify the responsive_images field to either append or remove it, and these new methods would be called from HTMLImageElement's bind_to_tree and unbind_from_tree methods.

jdm · 2018-08-01T22:07:44Z

components/script/dom/document.rs

+
+    pub fn responsive_images(&self) {
+        for image in self.responsive_images.iter() {
+            (*image).react_to_environment_changes();


nit: no need for (*) here.

This is being done to remove the Dom binding.

Right, but it shouldn't be necessary. The Rust compiler auto-dereferences for us.

jdm · 2018-08-01T22:07:44Z

components/script/dom/document.rs

@@ -2221,6 +2223,30 @@ impl Document {
        let counter = self.throw_on_dynamic_markup_insertion_counter.get();
        self.throw_on_dynamic_markup_insertion_counter.set(counter - 1);
    }
+
+    pub fn responsive_images(&self) {


Let's call this react_to_environment_changes.

jdm · 2018-08-01T22:07:44Z

components/script/dom/htmlimageelement.rs

@@ -120,7 +120,7 @@ enum ImageRequestPhase {
    Pending,
    Current
 }
-#[derive(JSTraceable, MallocSizeOf)]
+#[derive(Clone, JSTraceable, MallocSizeOf)]


I suspect we can find another solution instead of cloning, which would allow us to remove this and the one for LoadBlocker that was added.

jdm · 2018-08-01T22:07:44Z

components/script/dom/htmlimageelement.rs

-        let src = match selected_source {
-            Some(src) => src,
-            _ => return,
+        let (selected_source, selected_pixel_density) = match self.select_image_source() {


Let's add a // Steps 3-4 comment.

jdm · 2018-08-01T22:07:44Z

components/script/dom/node.rs

@@ -2669,7 +2669,7 @@ pub struct UnbindContext<'a> {

 impl<'a> UnbindContext<'a> {
    /// Create a new `UnbindContext` value.
-    fn new(parent: &'a Node,
+    pub fn new(parent: &'a Node,


This change isn't necessary.

jdm · 2018-08-01T22:07:44Z

components/script/dom/htmlimageelement.rs

+                // TODO: Handle multipart/x-mixed-replace
+                // Step 2 of https://html.spec.whatwg.org/multipage/#img-environment-changes,
+                let element = elem.upcast::<Element>();
+                let has_src = element.has_attribute(&local_name!("srcset"));


This check also needs to include the parent element, per https://html.spec.whatwg.org/multipage/images.html#use-srcset-or-picture . It would be nice to create a helper function that we could use in severalother places in the code.

jdm · 2018-08-01T22:07:44Z

components/script/dom/htmlimageelement.rs

+        let window = window_from_node(self);
+        let image_cache = window.image_cache();
+        let response =
+            image_cache.find_image_or_metadata(img_url.clone().into(),


Since we already perform this check in the caller, we should avoid duplicating it here. We can move all of the match arms into the caller, along with add_cache_listener_for_element, and then remove fetch_image_for_environment_change.

jdm · 2018-08-01T22:07:44Z

components/script/dom/htmlimageelement.rs

@@ -375,6 +437,22 @@ impl HTMLImageElement {
        window.add_pending_reflow();
    }

+    fn process_image_response_for_environment_change(&self, image: ImageResponse) {
+        let element = self.upcast::<Element>();
+        let is_multipart_x_mixed_replace = HTMLImageElement::check_mutipart_x_mixed_replace(element);


This check will need to happen as part of the process_response method, by obtaining the mime type of the Metadata object that is available there.

We were trying to check for the mime type as follows -

if let Some(metadata) = metadata { if let Some(mime) = metadata.content_type { let mime_type = String::from("x-mixed-replace"); match mime.into_inner() { ContentType::Mime(TopLevel::Multipart, SubLevel::Ext(s), _) => { if s == mime_type { self.abort_request(State::Unavailable, ImageRequestPhase::Pending); } }, _ => () } } }

ContentType has to be imported which is not possible because common module is private. Also we are unsure what to do in case of abort since we are inside ImageContext scope?

We are able to find the mime type correctly. But still stuck on how to abort here ?

The best way to abort is to add a field to ImageContext called aborted, set it to true, and return early from all of the handlers if aborted is true.

You can import ContentType from the hyper::header module: https://doc.servo.org/hyper/header/index.html

jdm · 2018-08-01T22:07:44Z

components/script/dom/htmlimageelement.rs

+            self.abort_request(State::Unavailable, ImageRequestPhase::Pending);
+        }
+
+        match (image, self.image_request.get()) {


We should just be able to match on image here. We will need to modify the contents of self.pending_request in order to store the image data and metadata in it when we they are available (ImageResponse::Loaded, ImageResponse::PlaceholderLoaded, ImageResponse::MetadataLoaded). When we have a fully loaded image, we should invoke finish_reacting_to_environment_changes.

In case of None, we still need to abort ?

nupurbaghel · 2018-08-02T18:57:40Z

We have updated all the suggested changes and ready for next review :)

paavininanda · 2018-08-03T04:32:02Z

We are having 16 Pass, 20 Fail, 8 Timeout now.

jdm · 2018-08-03T11:23:21Z

It would be worth figuring out which subtests fail or time out and why that occurs.

jdm

This is in very good shape! It's much more readable now and easier to follow when comparing it to the specification. Most of my comments are about improving the readability; the implementation looks good!

jdm · 2018-08-03T13:06:58Z

components/script/dom/document.rs

@@ -2221,6 +2223,21 @@ impl Document {
        let counter = self.throw_on_dynamic_markup_insertion_counter.get();
        self.throw_on_dynamic_markup_insertion_counter.set(counter - 1);
    }
+
+    pub fn react_to_environment_changes(&self) {
+        for image in self.responsive_images.borrow_mut().iter() {


This can use .borrow() instead.

jdm · 2018-08-03T13:06:58Z

components/script/dom/document.rs

+    }
+
+    pub fn unregister_responsive_image(&self, img: &HTMLImageElement) {
+        let index = self.responsive_images.borrow_mut().iter().position(|x| **x == *img).unwrap();


Instead of unwrapping, let's use if let to only call remove() when we find a matching value. We can use borrow instead of borrow_mut here, too.

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

@@ -178,6 +181,19 @@ impl FetchResponseListener for ImageContext {
            }
        });

+        if let Some(metadata) = metadata.as_ref() {


Let's add a comment to be clear that this is implementing part of the check in a particular step of the "reacting to the environment changes" algorithm (and which step that is).

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

+            if let Some(ref content_type) = metadata.content_type {
+                match content_type.clone().into_inner().0 {
+                    Mime(TopLevel::Multipart, SubLevel::Ext(s), _) => {
+                        if s == String::from("x-mixed-replace") {


We should be able to use s == "x-mixed-replace" here instead.

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

@@ -375,6 +396,31 @@ impl HTMLImageElement {
        window.add_pending_reflow();
    }

+    fn process_image_response_for_environment_change(&self, image: ImageResponse, src: DOMString, generation: u32,
+                                                     selected_pixel_density: f64) {


Let's format this as:

fn process_image_response_for_environment_change( &self, image: ImageResponse, src: DOMString, generation: u32, selected_pixel_density: f64) ) {

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

+
+                // Step 15.1
+                if relevant_mutation {
+                    this.abort_request(State::Unavailable, ImageRequestPhase::Pending);


We need to return after aborting the request.

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

+                    _ => false
+                };
+                // TODO Handle image/x-mixed-replace
+                if document.is_active() && has_src && !has_pending_request {


We should remove these checks now, since the exist inside react_to_environment_changes_sync_steps.

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

+            s.bind_to_tree(tree_in_doc);
+        }
+        let document = document_from_node(self);
+        document.register_responsive_image(self);


We should only call register_responsive_image when tree_in_doc is true.

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

+                    task!(process_image_response_for_environment_change: move || {
+                        let element = element.root();
+                        // Steps 3-4
+                        let (selected_source, selected_pixel_density) = match element.select_image_source() {


Instead of calling this, we should pass the selected source and density as arguments to add_cache_listener_for_element so we can use them inside this task.

This gives this error https://pastebin.com/yuwdVhTT

jdm · 2018-08-03T13:06:58Z

components/script/dom/htmlimageelement.rs

+
+    /// Step 2-12 of https://html.spec.whatwg.org/multipage/#img-environment-changes
+    fn react_to_environment_changes_sync_steps(&self, generation: u32) {
+        fn add_cache_listener_for_element(image_cache: Arc<ImageCache>,


Let's add a TODO comment about reducing the duplicating between this code and the code for regular image fetching. We can file a followup issue to address that.

bors-servo · 2018-09-11T22:36:07Z

💔 Test failed - linux-rel-css

jdm · 2018-09-11T22:45:35Z

@bors-servo retry

#21682

bors-servo · 2018-09-11T23:39:26Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...

bors-servo · 2018-09-11T23:54:17Z

💔 Test failed - linux-rel-css

KiChjang · 2018-09-12T01:27:52Z

More passing tests!

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e36a 50w, /images/green-16x16.png?e36a 51w\" sizes=\"min(1px, 100px)\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74455, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e36b 50w, /images/green-16x16.png?e36b 51w\" sizes=\"min(-100px, 1px)\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74456, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e37a 50w, /images/green-16x16.png?e37a 51w\" sizes=\"(min-width:0) min(1px, 100px)\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74458, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e37b 50w, /images/green-16x16.png?e37b 51w\" sizes=\"(min-width:0) max(-100px, 1px)\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74459, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e38 50w, /images/green-16x16.png?e38 51w\" sizes=\"(min-width:calc(0)) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74460, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e38a 50w, /images/green-16x16.png?e38a 51w\" sizes=\"(min-width:min(0, 200vw)) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74461, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e38b 50w, /images/green-16x16.png?e38b 51w\" sizes=\"(min-width:max(-200vw, 0)) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74462, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e58 50w, /images/green-16x16.png?e58 51w\" sizes=\"(min-width:0) or (unknown-mf-name) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74482, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e59 50w, /images/green-16x16.png?e59 51w\" sizes=\"(min-width:0) or (min-width:unknown-mf-value) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74483, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e60 50w, /images/green-16x16.png?e60 51w\" sizes=\"(min-width:0) or (min-width:-1px) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74484, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e61 50w, /images/green-16x16.png?e61 51w\" sizes=\"(min-width:0) or (unknown &quot;general-enclosed&quot;) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74485, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e62 50w, /images/green-16x16.png?e62 51w\" sizes=\"(min-width:0) or unknown-general-enclosed(foo) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74486, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?e106 50w, /images/green-16x16.png?e106 51w\" sizes=\"(min-width:0) or (unknown-general-enclosed !) 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74530, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?f48a 50w, /images/green-16x16.png?f48a 51w\" sizes=\"min(1px, 200vw\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74535, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?f48b 50w, /images/green-16x16.png?f48b 51w\" sizes=\"max(-200vw, 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74536, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?f49a 50w, /images/green-16x16.png?f49a 51w\" sizes=\"(min-width:0) min(1px, 200vw\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74538, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<img srcset=\"/images/green-1x1.png?f49b 50w, /images/green-16x16.png?f49b 51w\" sizes=\"(min-width:0) max(-200vw, 1px\"> ref sizes=\"1px\" (standards mode)", "test": "/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-standards-mode.html", "line": 74539, "action": "test_result", "expected": "FAIL"}

jdm · 2018-09-12T03:28:31Z

We'll need to add that test name to the title of the intermittent issue.

jdm · 2018-09-12T12:21:40Z

@bors-servo retry

#21666

bors-servo · 2018-09-12T13:21:01Z

⌛ Testing commit 2de300d with merge 16a3406...


        Auto merge of #21280 - paavininanda:Update_the_image_data, r=jdm

Reacting to environment changes  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix a subset of #11416  - [x] These changes do not require tests because they will be added when the complete responsive images is complete    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21280)

bors-servo · 2018-09-12T13:41:38Z

💔 Test failed - linux-rel-css

jdm · 2018-09-12T13:48:22Z

@bors-servo retry
#21666

bors-servo · 2018-09-12T14:47:15Z

⌛ Testing commit 2de300d with merge 9a83ab6...


        Auto merge of #21280 - paavininanda:Update_the_image_data, r=jdm

Reacting to environment changes  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix a subset of #11416  - [x] These changes do not require tests because they will be added when the complete responsive images is complete    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21280)

bors-servo · 2018-09-12T15:38:26Z

💔 Test failed - mac-rel-css1

jdm · 2018-09-12T15:49:04Z

@bors-servo retry

bors-servo · 2018-09-12T16:35:45Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1...

bors-servo · 2018-09-12T17:33:39Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 9a83ab6 to master...

highfive assigned gw3583 Jul 30, 2018

highfive added the S-awaiting-review label Jul 30, 2018

highfive assigned jdm and unassigned gw3583 Jul 30, 2018

jdm requested changes Jul 30, 2018

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Jul 30, 2018

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 1, 2018

paavininanda force-pushed the paavininanda:Update_the_image_data branch from a65f904 to 11c5ec3 Aug 1, 2018

jdm requested changes Aug 1, 2018

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Aug 1, 2018

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 2, 2018

paavininanda force-pushed the paavininanda:Update_the_image_data branch from 3098a4c to 7943397 Aug 2, 2018

jdm requested changes Aug 3, 2018

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Aug 3, 2018

paavininanda force-pushed the paavininanda:Update_the_image_data branch from f2daca2 to bfcee08 Aug 3, 2018

highfive added S-awaiting-review and removed S-needs-code-changes labels Aug 3, 2018

paavininanda force-pushed the paavininanda:Update_the_image_data branch from bfcee08 to 570cb75 Aug 3, 2018

jdm added the S-blocked-on-external label Aug 7, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 11, 2018

highfive added the S-tests-failed label Sep 11, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 12, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 12, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 12, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 12, 2018

bors-servo merged commit 2de300d into servo:master Sep 12, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

bors-servo mentioned this pull request Sep 12, 2018

Update hyper to 0.12 #21644

Merged

+                    );
+                }
+                return;

servo / servo

Join GitHub today

Reacting to environment changes #21280

Reacting to environment changes #21280

Conversation

paavininanda commented Jul 30, 2018 • edited

highfive commented Jul 30, 2018

highfive commented Jul 30, 2018

paavininanda commented Jul 30, 2018

jdm left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdm left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

paavininanda Aug 2, 2018 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nupurbaghel commented Aug 2, 2018

paavininanda commented Aug 3, 2018

jdm commented Aug 3, 2018

jdm left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors-servo commented Sep 11, 2018

jdm commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

KiChjang commented Sep 12, 2018

jdm commented Sep 12, 2018

jdm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

jdm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

jdm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

paavininanda commented Jul 30, 2018 •

edited

paavininanda Aug 2, 2018 •

edited