Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style: Use canonical naming and formatting #21282

Merged
merged 2 commits into from Aug 1, 2018
Merged

Code style: Use canonical naming and formatting #21282

merged 2 commits into from Aug 1, 2018

Conversation

@felixrabe
Copy link
Contributor

felixrabe commented Jul 30, 2018 •
edited by SimonSapin

This change is Reviewable
@felixrabe
Code style: Use canonical naming and formatting
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
290341a
@highfive
Copy link

highfive commented Jul 30, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.
@highfive
Copy link

highfive commented Jul 30, 2018

Heads up! This PR modifies the following files:
@emilio
emilio approved these changes Jul 30, 2018
View changes
Copy link
Member

emilio left a comment

Thanks!
ports/servo/browser.rs Outdated
warn!("Failed to send allow_navigation() response: {}", e);
EmbedderMsg::AllowNavigation(_url, sender) => {
if let Err(e) = sender.send(true) {
warn!("Failed to send AllowNavigation response: {}", e);
};

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Jul 30, 2018

Member

nit: While at it you may as well remove this stray semicolon :)
@felixrabe
Update browser.rs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
be31081
@jdm
Copy link
Member

jdm commented Jul 30, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2018

📌 Commit be31081 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2018

⌛ Testing commit be31081 with merge 4ec640c...
bors-servo added a commit that referenced this pull request Jul 30, 2018
@bors-servo
Auto merge of #21282 - felixrabe:patch-2, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4ec640c 
Code style: Use canonical naming and formatting

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21282)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Jul 30, 2018

@bors-servo retry

  • busted CI
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2018

⌛ Testing commit be31081 with merge 8cb0540...
bors-servo added a commit that referenced this pull request Jul 30, 2018
@bors-servo
Auto merge of #21282 - felixrabe:patch-2, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8cb0540 
Code style: Use canonical naming and formatting

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21282)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Jul 30, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2018

⌛ Testing commit be31081 with merge 5e521bf...
bors-servo added a commit that referenced this pull request Jul 30, 2018
@bors-servo
Auto merge of #21282 - felixrabe:patch-2, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5e521bf 
Code style: Use canonical naming and formatting

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21282)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

Manishearth commented Jul 31, 2018

going to temporarily close this while I test some things
@felixrabe
Copy link
Contributor Author

felixrabe commented Jul 31, 2018

lol I start to get the feeling that this tiny nitpick of mine is about to bring up some PTSD regarding CI infrastructure 🤭
@Manishearth Manishearth reopened this Jul 31, 2018
@Manishearth
Copy link
Member

Manishearth commented Jul 31, 2018

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

📌 Commit be31081 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Jul 31, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

⌛ Testing commit be31081 with merge a942750...
bors-servo added a commit that referenced this pull request Jul 31, 2018
@bors-servo
Auto merge of #21282 - felixrabe:patch-2, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a942750 
Code style: Use canonical naming and formatting

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21282)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

💔 Test failed - mac-rel-wpt1
@Manishearth
Copy link
Member

Manishearth commented Jul 31, 2018

@bors-servo retry

  • virtualenv disappeared ?
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

⌛ Testing commit be31081 with merge 78e90d6...
bors-servo added a commit that referenced this pull request Jul 31, 2018
@bors-servo
Auto merge of #21282 - felixrabe:patch-2, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
78e90d6 
Code style: Use canonical naming and formatting

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21282)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

💔 Test failed - mac-rel-wpt2
@KiChjang
Copy link
Member

KiChjang commented Jul 31, 2018

@bors-servo retry infra
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

⚡ Previous build results for android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-css2, windows-msvc-dev are reusable. Rebuilding only android, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented Aug 1, 2018

@bors-servo retry

  • cleaned out the build machine
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⚡ Previous build results for android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 78e90d6 to master...
@bors-servo bors-servo merged commit be31081 into servo:master Aug 1, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@felixrabe @highfive @jdm @bors-servo @Manishearth @KiChjang @emilio @mbrubeck
You can’t perform that action at this time.