Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch to pkg-config-rs from GIT for working around MSVC linking issues #21293
Conversation
highfive
commented
Jul 31, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon. |
highfive
commented
Jul 31, 2018
|
Heads up! This PR modifies the following files:
|
First of all it seems like zlib was taken from the GStreamer binaries (instead of whatever was there before) since the webaudio PR. Second it looks like this still uses the old I'll check this later. |
722f951
to
7ee86de
7ee86de
to
fb499cb
|
|
|
Closing in favour of #21515, which is literally the same change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sdroege commentedJul 31, 2018
•
edited
This PR removes a workaround from the appveyour setup which should be unneeded with latest pkg-config-rs. Previously for msvc builds the library paths were not taken into account properly.
Once this also works on the servo appveyour, a new pkg-config-rs release will be made and the patch section can be removed again from
Cargo.toml. I'll update the PR then../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is
cc @ferjm