Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not manually keep the modifiers state #21301

Merged
merged 1 commit into from Aug 1, 2018
Merged

Do not manually keep the modifiers state #21301

merged 1 commit into from Aug 1, 2018

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 1, 2018 •
edited by SimonSapin

Fix #21294

This change is Reviewable
@paulrouget
Do not manually keep the modifiers state
Loading status checks…
8c4d4a3
@paulrouget paulrouget mentioned this pull request Aug 1, 2018
Closed
@Manishearth
Copy link
Member

Manishearth commented Aug 1, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

📌 Commit 8c4d4a3 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⌛ Testing commit 8c4d4a3 with merge 88f3c8e...
bors-servo added a commit that referenced this pull request Aug 1, 2018
@bors-servo
Auto merge of #21301 - paulrouget:stickykeys, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
88f3c8e 
Do not manually keep the modifiers state

Fix #21294

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21301)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 88f3c8e to master...
@bors-servo bors-servo merged commit 8c4d4a3 into servo:master Aug 1, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Aug 1, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@paulrouget @Manishearth @bors-servo @highfive
You can’t perform that action at this time.