Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page size when device-pixel-ratio is set manually #21302

Merged
merged 1 commit into from Aug 7, 2018
Merged

Fix page size when device-pixel-ratio is set manually #21302

merged 1 commit into from Aug 7, 2018
+26 −21

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 1, 2018 •
edited by SimonSapin

Fix #21277

We were using the user-define pixel ratio to get the device values of the winit coordinates.

This change is Reviewable
@paulrouget
Fix page size when device-pixel-ratio is set manually
Loading status checks…
4dfe617
@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 6, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2018

📌 Commit 4dfe617 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2018

⌛ Testing commit 4dfe617 with merge d89f7b3...
bors-servo added a commit that referenced this pull request Aug 6, 2018
@bors-servo
Auto merge of #21302 - paulrouget:res, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d89f7b3 
Fix page size when device-pixel-ratio is set manually

Fix #21277

We were using the user-define pixel ratio to get the device values of the winit coordinates.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21302)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2018

💔 Test failed - android-x86
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 7, 2018

android-x86 is failing: #21349
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 7, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

⌛ Testing commit 4dfe617 with merge e363d57...
bors-servo added a commit that referenced this pull request Aug 7, 2018
@bors-servo
Auto merge of #21302 - paulrouget:res, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e363d57 
Fix page size when device-pixel-ratio is set manually

Fix #21277

We were using the user-define pixel ratio to get the device values of the winit coordinates.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21302)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

💔 Test failed - arm64
@jdm
Copy link
Member

jdm commented Aug 7, 2018

@bors-servo retry

  • cleaned up builder
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

⚡ Previous build results for android, android-x86, arm32, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only arm64, linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: mbrubeck
Pushing e363d57 to master...
@bors-servo bors-servo merged commit 4dfe617 into servo:master Aug 7, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @mbrubeck @bors-servo @jdm @highfive
You can’t perform that action at this time.