Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use a WebGLVertexArrayObject to handle vertex attribs #21307

Merged
merged 1 commit into from Aug 2, 2018
Merged

Always use a WebGLVertexArrayObject to handle vertex attribs #21307

merged 1 commit into from Aug 2, 2018

Conversation

@nox
Copy link
Member

nox commented Aug 1, 2018 •
edited by SimonSapin

This lets us clean up how buffers are reference-counted.

This change is Reviewable
@highfive
Copy link

highfive commented Aug 1, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/bindings/trace.rs and 2 more
  • @KiChjang: components/script/dom/webgl_extensions/ext/oesvertexarrayobject.rs, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/bindings/trace.rs and 2 more
@highfive
Copy link

highfive commented Aug 1, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Aug 1, 2018

A next nice step would be to make the vertex_attribs field just be a boxed slice where the items themselves use interior mutability.
@nox nox force-pushed the webgl branch 3 times, most recently from fea5a69 to 5d8552b Aug 1, 2018
@nox
Copy link
Member Author

nox commented Aug 1, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⌛ Trying commit 5d8552b with merge bfd924f...
bors-servo added a commit that referenced this pull request Aug 1, 2018
@bors-servo
Auto merge of #21307 - servo:webgl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bfd924f 
Always use a WebGLVertexArrayObject to handle vertex attribs

This lets us clean up how buffers are reference-counted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21307)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

💔 Test failed - linux-rel-css
@nox nox force-pushed the webgl branch from 5d8552b to 6233cf6 Aug 1, 2018
@highfive highfive removed the S-tests-failed label Aug 1, 2018
@nox
Copy link
Member Author

nox commented Aug 1, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⌛ Trying commit 6233cf6 with merge 3442337...
bors-servo added a commit that referenced this pull request Aug 1, 2018
@bors-servo
Auto merge of #21307 - servo:webgl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3442337 
Always use a WebGLVertexArrayObject to handle vertex attribs

This lets us clean up how buffers are reference-counted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21307)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

💔 Test failed - mac-rel-css2
@nox
Copy link
Member Author

nox commented Aug 1, 2018

@bors-servo retry

/_mozilla/mozilla/hit_test_multiple_sc.html seems intermittent.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⌛ Trying commit 6233cf6 with merge 66d69ef...
bors-servo added a commit that referenced this pull request Aug 1, 2018
@bors-servo
Auto merge of #21307 - servo:webgl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
66d69ef 
Always use a WebGLVertexArrayObject to handle vertex attribs

This lets us clean up how buffers are reference-counted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21307)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@nox nox force-pushed the webgl branch from 6233cf6 to a9d731a Aug 2, 2018
@highfive highfive removed the S-tests-failed label Aug 2, 2018
@emilio
emilio approved these changes Aug 2, 2018
View changes
@nox
Copy link
Member Author

nox commented Aug 2, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

📌 Commit a9d731a has been approved by emilio
@highfive highfive unassigned jdm Aug 2, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⌛ Testing commit a9d731a with merge 8267d3b...
bors-servo added a commit that referenced this pull request Aug 2, 2018
@bors-servo
Auto merge of #21307 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8267d3b 
Always use a WebGLVertexArrayObject to handle vertex attribs

This lets us clean up how buffers are reference-counted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21307)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

💔 Test failed - linux-rel-css
@nox
Always use a WebGLVertexArrayObject to handle vertex attribs
Loading status checks…
fba6d80 
This lets us clean up how buffers are reference-counted.
@nox nox force-pushed the webgl branch from a9d731a to fba6d80 Aug 2, 2018
@nox
Copy link
Member Author

nox commented Aug 2, 2018

#10776 (comment)

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

📌 Commit fba6d80 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⌛ Testing commit fba6d80 with merge a5fba3c...
bors-servo added a commit that referenced this pull request Aug 2, 2018
@bors-servo
Auto merge of #21307 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a5fba3c 
Always use a WebGLVertexArrayObject to handle vertex attribs

This lets us clean up how buffers are reference-counted.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21307)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing a5fba3c to master...
@bors-servo bors-servo merged commit fba6d80 into master Aug 2, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @bors-servo @emilio @jdm
You can’t perform that action at this time.