Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix JSON error when no arguments are passed #21308

Merged
merged 1 commit into from Aug 1, 2018
Merged

Android: Fix JSON error when no arguments are passed #21308

merged 1 commit into from Aug 1, 2018
+8 −6

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 1, 2018 •
edited by SimonSapin

Probably fix #21298

This change is Reviewable
@paulrouget
Android: Fix JSON error when no arguments are passed
Loading status checks…
fb8d8b3
@paulrouget paulrouget requested a review from jdm Aug 1, 2018
@jdm
Copy link
Member

jdm commented Aug 1, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

📌 Commit fb8d8b3 has been approved by jdm
@highfive highfive assigned jdm and unassigned gw3583 Aug 1, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⌛ Testing commit fb8d8b3 with merge 890d40d...
bors-servo added a commit that referenced this pull request Aug 1, 2018
@bors-servo
Auto merge of #21308 - paulrouget:jsonerror, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
890d40d 
Android: Fix JSON error when no arguments are passed

Probably fix #21298

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21308)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented Aug 1, 2018

@bors-servo retry

  • cleaned the builder
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

⚡ Previous build results for android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 890d40d to master...
@bors-servo bors-servo merged commit fb8d8b3 into servo:master Aug 1, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Aug 2, 2018
Open
1 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Servo for Android crashes on launch
5 participants
@paulrouget @jdm @bors-servo @highfive @gw3583
You can’t perform that action at this time.