Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer and renderbuffer fixes #21313

Merged
merged 2 commits into from Aug 2, 2018
Merged

Framebuffer and renderbuffer fixes #21313

merged 2 commits into from Aug 2, 2018
+181 −54

Conversation

@jdm
Copy link
Member

jdm commented Aug 1, 2018 •
edited by SimonSapin

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21252
  • There are tests for these changes

This change is Reviewable
@jdm
webgl: Mark zero-sized framebuffers as incomplete attachments.
3334e47
@highfive
Copy link

highfive commented Aug 1, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl_extensions/ext/oesstandardderivatives.rs, components/script/dom/webgl_extensions/ext/oeselementindexuint.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/webglrenderbuffer.rs and 1 more
  • @KiChjang: components/script/dom/webgl_extensions/ext/oesstandardderivatives.rs, components/script/dom/webgl_extensions/ext/oeselementindexuint.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/webglrenderbuffer.rs and 1 more
@highfive
Copy link

highfive commented Aug 1, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Aug 1, 2018

r? @nox
@highfive highfive assigned nox and unassigned avadacatavra Aug 1, 2018
@nox
Copy link
Member

nox commented Aug 1, 2018

r=me once the tidy issue is fixed.
@jdm jdm force-pushed the jdm:glstuff branch from 82394ad to d7c736e Aug 1, 2018
@jdm
Copy link
Member Author

jdm commented Aug 1, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

📌 Commit d7c736e has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⌛ Testing commit d7c736e with merge 376e43f...
bors-servo added a commit that referenced this pull request Aug 2, 2018
@bors-servo
Auto merge of #21313 - jdm:glstuff, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
376e43f 
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

💔 Test failed - mac-dev-unit
@jdm jdm force-pushed the jdm:glstuff branch from d7c736e to d85954a Aug 2, 2018
@jdm
Copy link
Member Author

jdm commented Aug 2, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

📌 Commit d85954a has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⌛ Testing commit d85954a with merge 2acbc3f...
bors-servo added a commit that referenced this pull request Aug 2, 2018
@bors-servo
Auto merge of #21313 - jdm:glstuff, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2acbc3f 
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

💔 Test failed - linux-rel-css
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

💔 Test failed - linux-rel-wpt
@jdm
webgl: Emulate some renderbuffer formats in non-GLES.
Loading status checks…
03eb7e4
@jdm jdm force-pushed the jdm:glstuff branch from 79b67d8 to 03eb7e4 Aug 2, 2018
@jdm
Copy link
Member Author

jdm commented Aug 2, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

📌 Commit 03eb7e4 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⌛ Testing commit 03eb7e4 with merge 84488d8...
bors-servo added a commit that referenced this pull request Aug 2, 2018
@bors-servo
Auto merge of #21313 - jdm:glstuff, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
84488d8 
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Aug 2, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⌛ Testing commit 03eb7e4 with merge bde8a1e...
bors-servo added a commit that referenced this pull request Aug 2, 2018
@bors-servo
Auto merge of #21313 - jdm:glstuff, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bde8a1e 
Framebuffer and renderbuffer fixes

This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Aug 2, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing bde8a1e to master...
@bors-servo bors-servo merged commit 03eb7e4 into servo:master Aug 2, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Aug 3, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

renderbufferStorage with RGB565 format causes panic in GL thread
5 participants
@jdm @highfive @nox @bors-servo @avadacatavra
You can’t perform that action at this time.