Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused compositing dependency from bluetooth crate #21346

Merged
merged 1 commit into from Aug 8, 2018
Merged

Remove unused compositing dependency from bluetooth crate #21346

merged 1 commit into from Aug 8, 2018
+0 −2

Conversation

@georgeroman
Copy link
Contributor

georgeroman commented Aug 5, 2018 •
edited by SimonSapin

Closes #21176

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@georgeroman
Remove unused compositing dependency from bluetooth crate
Loading status checks…
232addb
@highfive
Copy link

highfive commented Aug 5, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.
@paulrouget
Copy link
Contributor

paulrouget commented Aug 6, 2018

Looks good to me. Thank you.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2018

📌 Commit 232addb has been approved by paulrouget
@highfive highfive assigned paulrouget and unassigned nox Aug 6, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2018

⌛ Testing commit 232addb with merge 9d87c89...
bors-servo added a commit that referenced this pull request Aug 6, 2018
@bors-servo
Auto merge of #21346 - georgeroman:unused_bluetooth_dep, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d87c89 
Remove unused compositing dependency from bluetooth crate

Closes #21176

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2018

💔 Test failed - android-x86
@paulrouget
Copy link
Contributor

paulrouget commented Aug 7, 2018

Failure is unrelated: #21349
@paulrouget
Copy link
Contributor

paulrouget commented Aug 7, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

⌛ Testing commit 232addb with merge e2854ec...
bors-servo added a commit that referenced this pull request Aug 7, 2018
@bors-servo
Auto merge of #21346 - georgeroman:unused_bluetooth_dep, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e2854ec 
Remove unused compositing dependency from bluetooth crate

Closes #21176

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

💔 Test failed - arm64
@jdm
Copy link
Member

jdm commented Aug 7, 2018

@bors-servo retry

  • cleaned up builder
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

⌛ Testing commit 232addb with merge 7ae4fd3...
bors-servo added a commit that referenced this pull request Aug 7, 2018
@bors-servo
Auto merge of #21346 - georgeroman:unused_bluetooth_dep, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7ae4fd3 
Remove unused compositing dependency from bluetooth crate

Closes #21176

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member

jdm commented Aug 7, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

⌛ Testing commit 232addb with merge 831e291...
bors-servo added a commit that referenced this pull request Aug 7, 2018
@bors-servo
Auto merge of #21346 - georgeroman:unused_bluetooth_dep, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
831e291 
Remove unused compositing dependency from bluetooth crate

Closes #21176

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2018

💔 Test failed - mac-rel-wpt3
@paulrouget
Copy link
Contributor

paulrouget commented Aug 8, 2018

@bors-servo retry

#20734
@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2018

⌛ Testing commit 232addb with merge 5315977...
bors-servo added a commit that referenced this pull request Aug 8, 2018
@bors-servo
Auto merge of #21346 - georgeroman:unused_bluetooth_dep, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5315977 
Remove unused compositing dependency from bluetooth crate

Closes #21176

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2018

💔 Test failed - mac-rel-css2
@paulrouget
Copy link
Contributor

paulrouget commented Aug 8, 2018

@bors-servo retry

#20734
@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paulrouget
Pushing 5315977 to master...
@bors-servo bors-servo merged commit 232addb into servo:master Aug 8, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@paulrouget
Copy link
Contributor

paulrouget commented Aug 8, 2018

@georgeroman thank you :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@georgeroman @highfive @paulrouget @bors-servo @jdm @nox
You can’t perform that action at this time.