Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build for NLL #21356

Merged
merged 2 commits into from Aug 24, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Update getopts

  • Loading branch information
SimonSapin committed Aug 24, 2018
commit a9627d233f98da067fd8fc362b17174a00dd0430

Some generated files are not rendered by default. Learn more.

@@ -176,12 +176,17 @@ def extract_arg(name, args):


def extract_args(name, args):
assert "=" not in name
previous_arg_matches = False
for i, arg in enumerate(args):
if previous_arg_matches:
yield i, arg
previous_arg_matches = arg == name

arg, sep, value = arg.partition("=")
if arg == name and sep == "=":
yield i, value


def wait_for_tcp_server(adb, port):
while call(adb + ["shell", "nc -z 127.0.0.1 %s" % port], stdout=sys.stderr) != 0:
@@ -19,6 +19,6 @@ def start_servo(port, resolution):

# Use the below command if you are running this script on windows
# cmds = 'mach.bat run --webdriver ' + port + ' --resolution ' + resolution
cmds = './mach run --webdriver ' + port + ' --resolution ' + resolution
cmds = './mach run --webdriver=' + port + ' --resolution ' + resolution
process = subprocess.Popen(cmds, shell=True, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
return process
"support"
],
"tools/wptrunner/wptrunner/browsers/servodriver.py": [
"6486a788b8c8fbf4fc52dd4368265571975cabb4",
"d788effc469bc2f582ba7ead65700e7a13c37c59",
"support"
],
"tools/wptrunner/wptrunner/browsers/webkit.py": [
"support"
],
"tools/wptrunner/wptrunner/webdriver_server.py": [
"9ecd009a7d8127ed793d4ef0aff19f6161bbd1ec",
"4ec415ce78bb89a82d5f098b1c4e8560e7ec39e4",
"support"
],
"tools/wptrunner/wptrunner/wptcommandline.py": [
@@ -106,7 +106,7 @@ def start(self, **kwargs):
self.binary,
self.binary_args + [
"--hard-fail",
"--webdriver", str(self.webdriver_port),
"--webdriver=%s" % self.webdriver_port,
"about:blank",
],
self.debug_info
@@ -197,7 +197,7 @@ def __init__(self, logger, binary="servo", binary_args=None, host="127.0.0.1",

def make_command(self):
command = [self.binary,
"--webdriver", str(self.port),
"--webdriver=%s" % self.port,
"--hard-fail",
"--headless"] + self._args
if self.binary_args:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.