Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ndk-stack mach command #21366

Merged
merged 1 commit into from Aug 10, 2018
Merged

Add ndk-stack mach command #21366

merged 1 commit into from Aug 10, 2018

Conversation

@jdm
Copy link
Member

jdm commented Aug 8, 2018 •
edited by SimonSapin

This makes it much easier to get usable symbols from logcat output that includes a crash.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20442
  • These changes do not require tests because it's a mach command

This change is Reviewable
@jdm
mach: Add ndk-stack command for android crash logs.
Loading status checks…
ef66205
@highfive
Copy link

highfive commented Aug 8, 2018

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Aug 9, 2018

r? @paulrouget
@highfive highfive assigned paulrouget and unassigned nox Aug 9, 2018
@paulrouget
Copy link
Contributor

paulrouget commented Aug 10, 2018

Do you know I only see unwind symbols:

Stack frame #05 pc 048e6682  /data/app/com.mozilla.servo-obyBQcBwDD5wfYEjd8BViw==/lib/arm/libsimpleservo.so: Routine unw_get_reg at /Volumes/Android/buildbot/src/android/ndk-r12-release/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/src/Unwind/libunwind.cpp:164
Stack frame #06 pc 048e6281  /data/app/com.mozilla.servo-obyBQcBwDD5wfYEjd8BViw==/lib/arm/libsimpleservo.so: Routine _Unwind_VRS_Get_Internal(_Unwind_Context*, _Unwind_VRS_RegClass, unsigned int, _Unwind_VRS_DataRepresentation, void*) at /Volumes/Android/buildbot/src/android/ndk-r12-release/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/src/Unwind/Unwind-EHABI.cpp:844
Stack frame #07 pc 048cf218  /data/app/com.mozilla.servo-obyBQcBwDD5wfYEjd8BViw==/lib/arm/libsimpleservo.so: Routine __gnu_Unwind_RaiseException at /Volumes/Android/buildbot/src/android/gcc/toolchain/build/../gcc/gcc-4.9/libgcc/unwind-arm-common.inc:432
Stack frame #08 pc 048cfd5c  /data/app/com.mozilla.servo-obyBQcBwDD5wfYEjd8BViw==/lib/arm/libsimpleservo.so: Routine _Unwind_RaiseException at /Volumes/Android/buildbot/src/android/gcc/toolchain/build/../gcc/gcc-4.9/libgcc/config/arm/libunwind.S:356
@jdm
Copy link
Member Author

jdm commented Aug 10, 2018

@bors-servo r=paul
<paul> jdm: alright. So it's not just me. Feel free to land #21366 then.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

📌 Commit ef66205 has been approved by paul
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

⌛ Testing commit ef66205 with merge e40feab...
bors-servo added a commit that referenced this pull request Aug 10, 2018
@bors-servo
Auto merge of #21366 - jdm:android-ndk-stack, r=paul
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e40feab 
Add ndk-stack mach command

This makes it much easier to get usable symbols from logcat output that includes a crash.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20442
- [x] These changes do not require tests because it's a mach command

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21366)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member Author

jdm commented Aug 10, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paul
Pushing e40feab to master...
@bors-servo bors-servo mentioned this pull request Aug 10, 2018
Merged
4 of 5 tasks complete
@bors-servo bors-servo merged commit ef66205 into servo:master Aug 10, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Make it easy to run ndk-stack with the right symbols
5 participants
@jdm @highfive @paulrouget @bors-servo @nox
You can’t perform that action at this time.