Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running simple wdspec tests #21370

Closed
wants to merge 2 commits into from
Closed

Start running simple wdspec tests #21370

wants to merge 2 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Aug 9, 2018 •
edited by SimonSapin

We should validate our webdriver implementation using the tests that exist for that purpose. This change gets that ball rolling.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
jdm added 2 commits Jul 16, 2018
@jdm
Initial results for webdriver conformance tests.
0ce48d4
@jdm
Pass a bunch of new_session wdspec tests.
Loading status checks…
7959231
@highfive
Copy link

highfive commented Aug 9, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/lib.rs, tests/wpt/include.ini
@jdm
Copy link
Member Author

jdm commented Aug 9, 2018

@bors-servo try
bors-servo added a commit that referenced this pull request Aug 9, 2018
@bors-servo
Auto merge of #21370 - jdm:wdspec, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d337e89 
Start running simple wdspec tests

We should validate our webdriver implementation using the tests that exist for that purpose. This change gets that ball rolling.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21370)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2018

⌛ Trying commit 7959231 with merge d337e89...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Aug 9, 2018

Clearly this is not ready for merging yet.
@jdm
Copy link
Member Author

jdm commented Aug 9, 2018

This also broke the android-x86 tests:

 0:37.29 WARNING Failed to start protocol connection
 0:37.29 ERROR Traceback (most recent call last):
  File "/home/servo/buildbot/slave/android-x86/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/protocol.py", line 47, in setup
    self.connect()
  File "/home/servo/buildbot/slave/android-x86/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/executorservodriver.py", line 99, in connect
    self.session.start()
  File "/home/servo/buildbot/slave/android-x86/build/tests/wpt/web-platform-tests/tools/webdriver/webdriver/client.py", line 415, in start
    value = self.send_command("POST", "session", body=body)
  File "/home/servo/buildbot/slave/android-x86/build/tests/wpt/web-platform-tests/tools/webdriver/webdriver/client.py", line 463, in send_command
    raise err
InvalidArgumentException: invalid argument (400): Unsupported legacy arguments
@jdm jdm mentioned this pull request Oct 16, 2018
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this pull request Oct 17, 2018
@bors-servo
Auto merge of #21965 - servo:jdm-patch-13, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
45ac424 
Return the expected response when webdriver requests a session deletion.

This fixes a mistake that I have to deal with every time I try to use our webdriver server implementation for something new. We don't have any automated tests for this functionality yet (#21370) but I want to stop stumbling over it.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because ¯\\\_(ツ)\_/¯

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21965)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

☔ The latest upstream changes (presumably #21644) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm jdm mentioned this pull request Jan 5, 2019
Closed
@jdm jdm closed this Jul 4, 2019
@jdm jdm deleted the jdm:wdspec branch Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-awaiting-review S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @highfive @bors-servo @emilio
You can’t perform that action at this time.