Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustfmt command to devenv commands #21376

Merged
merged 3 commits into from Aug 10, 2018
Merged

Add rustfmt command to devenv commands #21376

merged 3 commits into from Aug 10, 2018

Conversation

@JoshBrudnak
Copy link
Contributor

JoshBrudnak commented Aug 10, 2018 •
edited by tigercosmos

Added the rustfmt command to devenv commands which runs cargo fmt on a specified directory.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21374
  • There are tests for these changes OR
  • These changes do not require tests because they only included a simple command that was added to the devenv_commands python script.

This change is Reviewable
@JoshBrudnak
Add rustfmt command to devenv commands
Loading status checks…
fc0a86c
@highfive
Copy link

highfive commented Aug 10, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.
@highfive
Copy link

highfive commented Aug 10, 2018

Heads up! This PR modifies the following files:
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

☔ The latest upstream changes (presumably #21366) made this pull request unmergeable. Please resolve the merge conflicts.
@JoshBrudnak
Merge branch 'master' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
230f025
@jdm
Copy link
Member

jdm commented Aug 10, 2018

./mach test-tidy reports some warnings:

./python/servo/devenv_commands.py:231: W293 blank line contains whitespace
./python/servo/devenv_commands.py:244: W293 blank line contains whitespace
./python/servo/devenv_commands.py:231: trailing whitespace
./python/servo/devenv_commands.py:244: trailing whitespace
@jdm jdm added S-fails-tidy and removed S-needs-rebase labels Aug 10, 2018
@jdm
Copy link
Member

jdm commented Aug 10, 2018

Otherwise these changes look good.
@jdm jdm removed the S-awaiting-review label Aug 10, 2018
@jdm jdm assigned jdm and unassigned avadacatavra Aug 10, 2018
@JoshBrudnak
Remove trailing whitespace in devenv_commands
Loading status checks…
936ec08
@jdm
Copy link
Member

jdm commented Aug 10, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

📌 Commit 936ec08 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

⌛ Testing commit 936ec08 with merge c362ade...
bors-servo added a commit that referenced this pull request Aug 10, 2018
@bors-servo
Auto merge of #21376 - JoshBrudnak:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c362ade 
Add rustfmt command to devenv commands

Added the rustfmt command to devenv commands which runs cargo fmt on a specified directory.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21374

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only included a simple command that was added to the devenv_commands python script.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21376)
<!-- Reviewable:end -->
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 10, 2018

Uh, there's a merge commit.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing c362ade to master...
@bors-servo bors-servo merged commit 936ec08 into servo:master Aug 10, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add a mach command to run rustfmt
6 participants
@JoshBrudnak @highfive @bors-servo @jdm @wafflespeanut @avadacatavra
You can’t perform that action at this time.