Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few fixes to support Crow #21385

Merged
merged 3 commits into from Aug 11, 2018
Merged

Few fixes to support Crow #21385

merged 3 commits into from Aug 11, 2018
+22 −9

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 11, 2018 •
edited by SimonSapin

With these fixes, the published AAR works for both Android and Crow.

This change is Reviewable
paulrouget added 3 commits Aug 11, 2018
@paulrouget
Add asset to AAR
f1a2862
@paulrouget
fix mGLLooperHandler null ref
927704b
@paulrouget
Execute callbacks in proper threads
Loading status checks…
b16b0b4
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 11, 2018 •
edited

Works with https://github.com/paulrouget/AndroidServoView + https://github.com/paulrouget/FirefoxReality/tree/servo
@jdm
Copy link
Member

jdm commented Aug 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2018

📌 Commit b16b0b4 has been approved by jdm
@highfive highfive assigned jdm and unassigned avadacatavra Aug 11, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2018

⌛ Testing commit b16b0b4 with merge cabf47b...
bors-servo added a commit that referenced this pull request Aug 11, 2018
@bors-servo
Auto merge of #21385 - paulrouget:crowSupport, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cabf47b 
Few fixes to support Crow

With these fixes, the published AAR works for both Android and Crow.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21385)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Aug 11, 2018

@bors-servo retry #21383
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing cabf47b to master...
@bors-servo bors-servo merged commit b16b0b4 into servo:master Aug 11, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @jdm @bors-servo @highfive @avadacatavra
You can’t perform that action at this time.