Android: Use info! instead of debug! #21391

paulrouget · 2018-08-13T08:16:38Z

As explained in #21390, we are missing some important logs in release builds, and nightly is not available as a debug build for testers.

For the most important logs, let's use info instead of debug.

This change is

KiChjang · 2018-08-13T09:42:28Z

@bors-servo r+

bors-servo · 2018-08-13T09:42:29Z

📌 Commit 1b74f7c has been approved by KiChjang


        Auto merge of #21391 - paulrouget:debug_to_info, r=KiChjang

Android: Use info! instead of debug! Fix #21390 As explained in #21390, we are missing some important logs in release builds, and nightly is not available as a debug build for testers. For the most important logs, let's use `info` instead of `debug`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21391)

bors-servo · 2018-08-13T09:42:35Z

⌛ Testing commit 1b74f7c with merge ab34802...

paulrouget · 2018-08-13T10:04:38Z

I've added some gl logs.

@bors-servo r=KiChjang

bors-servo · 2018-08-13T10:04:38Z

📌 Commit b11cdb4 has been approved by KiChjang

bors-servo · 2018-08-13T10:04:43Z

⌛ Testing commit b11cdb4 with merge f2df6de...


        Auto merge of #21391 - paulrouget:debug_to_info, r=KiChjang

Android: Use info! instead of debug! Fix #21390 As explained in #21390, we are missing some important logs in release builds, and nightly is not available as a debug build for testers. For the most important logs, let's use `info` instead of `debug`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21391)

bors-servo · 2018-08-13T10:19:59Z

💔 Test failed - linux-rel-css

jdm · 2018-08-13T14:26:43Z

@bors-servo retry

#19937

bors-servo · 2018-08-13T14:26:47Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android-x86, linux-rel-css...

bors-servo · 2018-08-13T14:45:48Z

💔 Test failed - android-x86

paulrouget · 2018-08-14T07:26:30Z

@bors-servo r=KiChjang,SimonSapin

bors-servo · 2018-08-14T07:26:30Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #21394

bors-servo · 2018-08-14T07:26:31Z

📌 Commit ce64bd3 has been approved by KiChjang,SimonSapin

bors-servo · 2018-08-14T07:43:10Z

⌛ Testing commit ce64bd3 with merge f5f2875...


        Auto merge of #21391 - paulrouget:debug_to_info, r=KiChjang,SimonSapin

Android: Use info! instead of debug! Fix #21390 As explained in #21390, we are missing some important logs in release builds, and nightly is not available as a debug build for testers. For the most important logs, let's use `info` instead of `debug`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21391)

bors-servo · 2018-08-14T07:52:10Z

💔 Test failed - mac-rel-css1

paulrouget · 2018-08-14T08:48:09Z

@bors-servo retry

clang segfaulted?

bors-servo · 2018-08-14T08:48:12Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android-x86, linux-rel-css, mac-rel-css1...

bors-servo · 2018-08-14T09:07:00Z

💔 Test failed - android-x86

paulrouget · 2018-08-14T09:45:55Z

So write() fails. But it works here.

SimonSapin · 2018-08-14T10:21:58Z

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128)

  File "/home/servo/buildbot/slave/android-x86/build/python/servo/testing_commands.py", line 592, in test_android_startup
    sys.stdout.write(line)
  File "/usr/lib/python2.7/codecs.py", line 369, in write
    data, consumed = self.encode(object, self.errors)

This shows that:

We’re on Python 2.7
Calling sys.stdout.write ends up in codecs.StreamWriter.write https://hg.python.org/cpython/file/2.7/Lib/codecs.py#l369. So sys.stdout is a StreamWriter? That class wraps a byte stream and makes it a Unicode stream.

But as far as I remember, sys.stdout is supposed to be a byte stream on Python 2.x. (Only on 3.x is it a Unicode stream.) Is some other bit of code monkey-patching the sys module?


        Use info instead of debug

paulrouget · 2018-08-14T12:53:15Z

I'll file a specific issue for the utf8 error. For now, I'll remove the extra …character from the logs.

@bors-servo r=KiChjang

bors-servo · 2018-08-14T12:53:16Z

📌 Commit bfb76f6 has been approved by KiChjang

bors-servo · 2018-08-14T13:23:23Z

⌛ Testing commit bfb76f6 with merge 9aaf730...


        Auto merge of #21391 - paulrouget:debug_to_info, r=KiChjang

Android: Use info! instead of debug! Fix #21390 As explained in #21390, we are missing some important logs in release builds, and nightly is not available as a debug build for testers. For the most important logs, let's use `info` instead of `debug`.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21391)

bors-servo · 2018-08-14T15:09:41Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: KiChjang
Pushing 9aaf730 to master...

paulrouget force-pushed the paulrouget:debug_to_info branch from 81fde06 to 1b74f7c Aug 13, 2018

highfive assigned nox Aug 13, 2018

highfive added the S-awaiting-review label Aug 13, 2018

paulrouget changed the title ~~Use info instead of debug~~ Android: Use info! instead of debug! Aug 13, 2018

This was referenced Aug 13, 2018

Servo for Android crashes trying to load servo.org #21317

Open

debug! messages don't show up in logcat. warn! and info! do. #21390

Closed

highfive assigned KiChjang and unassigned nox Aug 13, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 13, 2018

paulrouget force-pushed the paulrouget:debug_to_info branch from 1b74f7c to b11cdb4 Aug 13, 2018

highfive added S-awaiting-review and removed S-awaiting-merge labels Aug 13, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 13, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 13, 2018

highfive added the S-tests-failed label Aug 13, 2018

highfive assigned KiChjang and unassigned SimonSapin Aug 14, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 14, 2018

highfive added the S-tests-failed label Aug 14, 2018

paulrouget force-pushed the paulrouget:debug_to_info branch from ce64bd3 to 5c7ef80 Aug 14, 2018

highfive added S-awaiting-review and removed S-tests-failed labels Aug 14, 2018

Use info instead of debug

Loading status checks…

bfb76f6

paulrouget force-pushed the paulrouget:debug_to_info branch from 5c7ef80 to bfb76f6 Aug 14, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 14, 2018

bors-servo merged commit bfb76f6 into servo:master Aug 14, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Aug 14, 2018

servo / servo

Android: Use info! instead of debug! #21391

Android: Use info! instead of debug! #21391

paulrouget commented Aug 13, 2018 •

edited by SimonSapin

KiChjang commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

paulrouget commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

jdm commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

paulrouget commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

paulrouget commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

paulrouget commented Aug 14, 2018

SimonSapin commented Aug 14, 2018

paulrouget commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

servo / servo

Join GitHub today

Android: Use info! instead of debug! #21391

Android: Use info! instead of debug! #21391

Conversation

paulrouget commented Aug 13, 2018 • edited by SimonSapin

KiChjang commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

paulrouget commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

jdm commented Aug 13, 2018

bors-servo commented Aug 13, 2018

bors-servo commented Aug 13, 2018

paulrouget commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

paulrouget commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

paulrouget commented Aug 14, 2018

SimonSapin commented Aug 14, 2018

paulrouget commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

bors-servo commented Aug 14, 2018

paulrouget commented Aug 13, 2018 •

edited by SimonSapin