Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CEReactions. #21394

Merged
merged 1 commit into from Aug 15, 2018
Merged

Remove unnecessary CEReactions. #21394

merged 1 commit into from Aug 15, 2018

Conversation

@jdm
Copy link
Member

jdm commented Aug 13, 2018

This incorporates a spec update in whatwg/html#3901.


This change is Reviewable

This incorporates a spec update in whatwg/html#3901.
@highfive
Copy link

highfive commented Aug 13, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/HTMLTextAreaElement.webidl
  • @KiChjang: components/script/dom/webidls/HTMLTextAreaElement.webidl
@highfive
Copy link

highfive commented Aug 13, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@cbrewster
Copy link
Member

cbrewster commented Aug 14, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

📌 Commit 6d3ff9f has been approved by cbrewster

@highfive highfive assigned cbrewster and unassigned emilio Aug 14, 2018
bors-servo added a commit that referenced this pull request Aug 14, 2018
Remove unnecessary CEReactions.

This incorporates a spec update in whatwg/html#3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

Testing commit 6d3ff9f with merge 433f104...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - linux-rel-css

@jdm
Copy link
Member Author

jdm commented Aug 14, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

Testing commit 6d3ff9f with merge 40140cf...

bors-servo added a commit that referenced this pull request Aug 14, 2018
Remove unnecessary CEReactions.

This incorporates a spec update in whatwg/html#3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - mac-rel-wpt4

@jdm
Copy link
Member Author

jdm commented Aug 14, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

Testing commit 6d3ff9f with merge feb937b...

bors-servo added a commit that referenced this pull request Aug 14, 2018
Remove unnecessary CEReactions.

This incorporates a spec update in whatwg/html#3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - windows-msvc-dev

@jdm
Copy link
Member Author

jdm commented Aug 14, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

Testing commit 6d3ff9f with merge 9375ac6...

bors-servo added a commit that referenced this pull request Aug 14, 2018
Remove unnecessary CEReactions.

This incorporates a spec update in whatwg/html#3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - linux-rel-css

@jdm
Copy link
Member Author

jdm commented Aug 14, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

Testing commit 6d3ff9f with merge 197ff81...

bors-servo added a commit that referenced this pull request Aug 14, 2018
Remove unnecessary CEReactions.

This incorporates a spec update in whatwg/html#3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - mac-rel-wpt1

@jdm
Copy link
Member Author

jdm commented Aug 15, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

Testing commit 6d3ff9f with merge 3ccfc28...

bors-servo added a commit that referenced this pull request Aug 15, 2018
Remove unnecessary CEReactions.

This incorporates a spec update in whatwg/html#3901.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

@bors-servo bors-servo merged commit 6d3ff9f into master Aug 15, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-6 branch Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.