New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behave properly when app is suspended #21405

Merged
merged 1 commit into from Aug 15, 2018

Conversation

Projects
None yet
5 participants
@paulrouget
Contributor

paulrouget commented Aug 14, 2018

Fix #21329


This change is Reviewable

@jdm

This comment has been minimized.

Member

jdm commented Aug 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

📌 Commit 1210328 has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Aug 14, 2018

@paulrouget paulrouget force-pushed the paulrouget:suspend branch from 1210328 to ae407e9 Aug 14, 2018

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Aug 14, 2018

@bors-servo r=jdm

  • Forgot to add refresh to capi.rs
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

📌 Commit ae407e9 has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

⌛️ Testing commit ae407e9 with merge e8ca54e...

bors-servo added a commit that referenced this pull request Aug 14, 2018

Auto merge of #21405 - paulrouget:suspend, r=jdm
Behave properly when app is suspended

Fix #21329

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21405)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - windows-msvc-dev

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Aug 14, 2018

@jdm

This comment has been minimized.

Member

jdm commented Aug 14, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

⌛️ Testing commit ae407e9 with merge 0df7fb9...

bors-servo added a commit that referenced this pull request Aug 14, 2018

Auto merge of #21405 - paulrouget:suspend, r=jdm
Behave properly when app is suspended

Fix #21329

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21405)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Aug 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

💔 Test failed - android-x86

@jdm

This comment has been minimized.

Member

jdm commented Aug 15, 2018

@bors-servo retry

  • killed the stuck emulator
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

💔 Test failed - android-x86

@jdm

This comment has been minimized.

Member

jdm commented Aug 15, 2018

@bors-servo retry

  • actually killed the process

bors-servo added a commit that referenced this pull request Aug 15, 2018

Auto merge of #21405 - paulrouget:suspend, r=jdm
Behave properly when app is suspended

Fix #21329

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21405)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

⌛️ Testing commit ae407e9 with merge e855973...

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

@bors-servo bors-servo merged commit ae407e9 into servo:master Aug 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment