Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behave properly when app is suspended #21405

Merged
merged 1 commit into from Aug 15, 2018
Merged

Behave properly when app is suspended #21405

merged 1 commit into from Aug 15, 2018

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 14, 2018 •
edited by SimonSapin

Fix #21329

This change is Reviewable
@jdm
Copy link
Member

jdm commented Aug 14, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

📌 Commit 1210328 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Aug 14, 2018
@paulrouget
Behave properly when app is suspended
Loading status checks…
ae407e9
@paulrouget paulrouget force-pushed the paulrouget:suspend branch from 1210328 to ae407e9 Aug 14, 2018
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 14, 2018

@bors-servo r=jdm

  • Forgot to add refresh to capi.rs
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

📌 Commit ae407e9 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

⌛ Testing commit ae407e9 with merge e8ca54e...
bors-servo added a commit that referenced this pull request Aug 14, 2018
@bors-servo
Auto merge of #21405 - paulrouget:suspend, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e8ca54e 
Behave properly when app is suspended

Fix #21329

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21405)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - windows-msvc-dev
@paulrouget paulrouget mentioned this pull request Aug 14, 2018
Closed
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 14, 2018

#21406
@jdm
Copy link
Member

jdm commented Aug 14, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

⌛ Testing commit ae407e9 with merge 0df7fb9...
bors-servo added a commit that referenced this pull request Aug 14, 2018
@bors-servo
Auto merge of #21405 - paulrouget:suspend, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0df7fb9 
Behave properly when app is suspended

Fix #21329

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21405)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Aug 14, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android-x86, linux-rel-wpt, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

💔 Test failed - android-x86
@jdm
Copy link
Member

jdm commented Aug 15, 2018

@bors-servo retry

  • killed the stuck emulator
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only android-x86...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

💔 Test failed - android-x86
@jdm
Copy link
Member

jdm commented Aug 15, 2018

@bors-servo retry

  • actually killed the process
bors-servo added a commit that referenced this pull request Aug 15, 2018
@bors-servo
Auto merge of #21405 - paulrouget:suspend, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e855973 
Behave properly when app is suspended

Fix #21329

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21405)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

⌛ Testing commit ae407e9 with merge e855973...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 15, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing e855973 to master...
@bors-servo bors-servo merged commit ae407e9 into servo:master Aug 15, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @jdm @bors-servo @Manishearth @highfive
You can’t perform that action at this time.