Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Switch text decoration computation over to a derived property #2141
Conversation
`-servo-text-decorations-in-effect`. This mirrors what WebKit does; WebKit's property is called `-webkit-text-decorations-in-effect`. It allows us to simplify a lot of layout code--most notably, the `FlowFlagsInfo` is gone. This commit is a necessary predecessor to removal of `InlineParentInfo`, which itself is a necessary predecessor to reenabling parallel layout.
highfive
commented
Apr 17, 2014
|
|
hoppipolla-critic-bot
commented
Apr 17, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1289 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Closing in favor of #2174. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedApr 17, 2014
-servo-text-decorations-in-effect.This mirrors what WebKit does; WebKit's property is called
-webkit-text-decorations-in-effect. It allows us to simplify a lot oflayout code--most notably, the
FlowFlagsInfois gone. This commit is anecessary predecessor to removal of
InlineParentInfo, which itself isa necessary predecessor to reenabling parallel layout.
r? @SimonSapin