New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle secure websockets #21424

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
5 participants
@Eijebong
Member

Eijebong commented Aug 15, 2018

Fixes #20816


This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Aug 15, 2018

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/connector.rs, components/net/websocket_loader.rs
@Eijebong

This comment has been minimized.

Member

Eijebong commented Aug 15, 2018

Me looking at the tests:

pass

@Eijebong

This comment has been minimized.

Member

Eijebong commented Aug 15, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

⌛️ Trying commit 73ef02f with merge eb9c3d0...

bors-servo added a commit that referenced this pull request Aug 15, 2018

Auto merge of #21424 - Eijebong:we-secure-now, r=<try>
Handle secure websockets

Fixes #20816

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21424)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 15, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@jdm

This comment has been minimized.

Member

jdm commented Aug 16, 2018

@bors-servo r+
Wonderful!

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 16, 2018

📌 Commit 73ef02f has been approved by jdm

@highfive highfive assigned jdm and unassigned gw3583 Aug 16, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 16, 2018

⌛️ Testing commit 73ef02f with merge 89ab110...

bors-servo added a commit that referenced this pull request Aug 16, 2018

Auto merge of #21424 - Eijebong:we-secure-now, r=jdm
Handle secure websockets

Fixes #20816

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21424)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 16, 2018

@bors-servo bors-servo merged commit 73ef02f into servo:master Aug 16, 2018

3 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment