Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPinch to zoom #21431
Merged
Pinch to zoom #21431
Conversation
|
Pinch to zoom works great unless there's text in the webpage. Not sure what's going on, but 1) text glyphs are getting messed up 2) servo gets extremely slow (depending on the amount of text). I filed an issue for this: #21432 |
|
Nice idea to add the indicator. |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 16, 2018
Pinch to zoom Implement pinch to zoom. Also, I added a marker in the toolbar to show if Servo is redrawing or not. The label switches from "IDLE" to "LOOP" when Servo is looping (at 60FPS) to redraw the page. Redrawing is necessary for 3 reasons: - a CSS animation is ongoing - scrolling - zooming This label is, for now, necessary to make sure we are not looping for not reason. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21303 (github issue number if applicable). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21431) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedAug 16, 2018
•
edited by SimonSapin
Implement pinch to zoom.
Also, I added a marker in the toolbar to show if Servo is redrawing or not.
The label switches from "IDLE" to "LOOP" when Servo is looping (at 60FPS) to redraw the page.
Redrawing is necessary for 3 reasons:
This label is, for now, necessary to make sure we are not looping for not reason.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is