Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List additional keyboard shortcuts #21460

Merged
merged 2 commits into from Aug 22, 2018
Merged

List additional keyboard shortcuts #21460

merged 2 commits into from Aug 22, 2018

Conversation

@atouchet
Copy link
Contributor

atouchet commented Aug 20, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@atouchet
List additional keyboard shortcuts
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ea53d81
@paulrouget
paulrouget reviewed Aug 20, 2018
View changes
README.md Outdated
@@ -283,11 +283,13 @@ Run Servo with the command:

### Keyboard Shortcuts

- `Ctrl`+`L` opens URL prompt
- `Ctrl`+`R` reloads current page

This comment has been minimized.

Sign in to view
@paulrouget

paulrouget Aug 20, 2018

Contributor

And Cmd for Mac.
README.md Outdated
@@ -283,11 +283,13 @@ Run Servo with the command:

### Keyboard Shortcuts

- `Ctrl`+`L` opens URL prompt
- `Ctrl`+`R` reloads current page
- `Ctrl`+`-` zooms out
- `Ctrl`+`=` zooms in

This comment has been minimized.

Sign in to view
@paulrouget

paulrouget Aug 20, 2018

Contributor

Cmd for Mac. But broken now: #21457
@atouchet
Add Mac shortcuts
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
305b109
@paulrouget
Copy link
Contributor

paulrouget commented Aug 22, 2018

Thank you!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2018

📌 Commit 305b109 has been approved by paulrouget
@highfive highfive assigned paulrouget and unassigned gw3583 Aug 22, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2018

⌛ Testing commit 305b109 with merge 9e2bbb7...
bors-servo added a commit that referenced this pull request Aug 22, 2018
@bors-servo
Auto merge of #21460 - atouchet:shortcuts, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e2bbb7 
List additional keyboard shortcuts

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21460)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2018

💔 Test failed - linux-rel-wpt
@paulrouget
Copy link
Contributor

paulrouget commented Aug 22, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paulrouget
Pushing 9e2bbb7 to master...
@bors-servo bors-servo merged commit 305b109 into servo:master Aug 22, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@atouchet atouchet deleted the atouchet:shortcuts branch Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrouget paulrouget

Assignees

@paulrouget paulrouget

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@atouchet @paulrouget @bors-servo @jdm @highfive @gw3583
You can’t perform that action at this time.