Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVarious webgl fixes for framebuffer attachment test #21461
Merged
Conversation
highfive
commented
Aug 20, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @nox |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 20, 2018
Various webgl fixes for framebuffer attachment test These changes resolve all panics on macOS when running framebuffer-object-attachment.html in headless and headful testing. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21461) <!-- Reviewable:end -->
|
|
|
@bors-servo test-wpt |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Aug 24, 2018
Various webgl fixes for framebuffer attachment test These changes resolve all panics on macOS when running framebuffer-object-attachment.html in headless and headful testing. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21461) <!-- Reviewable:end -->
|
|
|
Need to look at:
|
components/canvas/webgl_thread.rs
Outdated
| @@ -1091,6 +1172,63 @@ impl WebGLImpl { | |||
| assert_eq!(error, gl::NO_ERROR, "Unexpected WebGL error: 0x{:x} ({})", error, error); | |||
| } | |||
|
|
|||
| #[allow(unsafe_code)] | |||
This comment has been minimized.
This comment has been minimized.
| @@ -200,6 +200,7 @@ pub struct WebGLRenderingContext { | |||
| current_scissor: Cell<(i32, i32, i32, i32)>, | |||
| #[ignore_malloc_size_of = "Because it's small"] | |||
| current_clear_color: Cell<(f32, f32, f32, f32)>, | |||
| #[ignore_malloc_size_of = "Because it's small"] | |||
This comment has been minimized.
This comment has been minimized.
|
The following expectations reference #13710:
AFAICT they are not all changed in your PR. Could you reenable them? Looks good to me otherwise, r=me. |
|
@bors-servo r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 11, 2018
Various webgl fixes for framebuffer attachment test These changes resolve all panics on macOS when running framebuffer-object-attachment.html in headless and headful testing. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR - [x] Fixes #13710. Fixes #20570. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21461) <!-- Reviewable:end -->
|
|
|
@jdm Could you disable the tests about uninitialised buffers again and make this land? |
|
@bors-servo r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 12, 2018
Various webgl fixes for framebuffer attachment test These changes resolve all panics on macOS when running framebuffer-object-attachment.html in headless and headful testing. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR - [x] Fixes #13710. Fixes #20570. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21461) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Sep 12, 2018
Various webgl fixes for framebuffer attachment test These changes resolve all panics on macOS when running framebuffer-object-attachment.html in headless and headful testing. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR - [x] Fixes #13710. Fixes #20570. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21461) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedAug 20, 2018
•
edited
These changes resolve all panics on macOS when running framebuffer-object-attachment.html in headless and headful testing.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is