Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to mozjs_sys 0.60.1 to get libc++ on macOS #21470
Merged
Conversation
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2018
Update to mozjs_sys 0.60.1 to get libc++ on macOS (WIP) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21470) <!-- Reviewable:end -->
|
|
|
Weird issue on Windows. @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2018
Update to mozjs_sys 0.60.1 to get libc++ on macOS (WIP) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21470) <!-- Reviewable:end -->
|
|
|
Well no idea what's going on with Windows, but the macOS build succeeded. The issue is that Travis is failing on mozjs too. |
nox
changed the title
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 22, 2018
Update to mozjs_sys 0.60.1 to get libc++ on macOS <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21470) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedAug 21, 2018
•
edited by SimonSapin
This change is