Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: macOs instructions on manual install of llvm #21484

Closed
wants to merge 1 commit into from

Conversation

@gterzian
Copy link
Member

gterzian commented Aug 22, 2018


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21478 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@nox
Copy link
Member

nox commented Aug 22, 2018

It works without installing the one from homebrew with servo/mozjs#146, AFAICT. It definitely works for me at least.

@gterzian gterzian force-pushed the gterzian:patch-1 branch 2 times, most recently from 7997ce4 to 037d1f2 Aug 22, 2018
@gterzian gterzian force-pushed the gterzian:patch-1 branch from 037d1f2 to 5251e86 Aug 22, 2018
@gterzian
Copy link
Member Author

gterzian commented Aug 22, 2018

It seems to work for me now as well, without the flag, after having uninstalled the llvm from homebrew... I guess the issue could provide some guidance in case someone stumbles on something similar in the future...

@gterzian gterzian closed this Aug 22, 2018
@gterzian gterzian deleted the gterzian:patch-1 branch Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.