Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioListener/AudioPanner DOM interfaces #21502

Merged
merged 12 commits into from Aug 25, 2018
+822 −340
Merged

Add AudioListener/AudioPanner DOM interfaces #21502

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4b48cfa
Upgrade to latest servo-media
Manishearth Aug 23, 2018
9228ca3
Add AudioListener DOM interface
Manishearth Aug 23, 2018
e4e01a6
Add PannerNode DOM interface
Manishearth Aug 23, 2018
43ea9e0
cleanup: Remove Rc from BaseAudioContext
Manishearth Aug 23, 2018
062c1d6
Add BaseAudioContext.createPanner()
Manishearth Aug 23, 2018
0f66f17
Add HTML test
Manishearth Aug 23, 2018
7d5b4b2
Add constraints for PannerNode
Manishearth Aug 24, 2018
7daec55
Add accessors for PannerNode
Manishearth Aug 24, 2018
18960b6
Add PannerNode.setPosition(), setOrientation()
Manishearth Aug 24, 2018
58176c4
Add some checks in PannerNode accessors
Manishearth Aug 24, 2018
5dd8303
Handle channel count constraints in panner constructor
Manishearth Aug 24, 2018
04e60e6
Update WPT expectations
Manishearth Aug 24, 2018
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev
Loading status checks…

Update WPT expectations

  • Loading branch information
@Manishearth
Manishearth committed Aug 24, 2018
commit 04e60e683a3307ee28e6b97730353cf23f4691c5
13 tests/wpt/metadata/webaudio/historical.html.ini
View file
Open in desktop

This file was deleted.

291 tests/wpt/metadata/webaudio/idlharness.https.window.js.ini
View file
Open in desktop
@@ -5,9 +5,6 @@
[Test driver]
expected: FAIL

[BaseAudioContext interface: attribute listener]
expected: FAIL

[BaseAudioContext interface: attribute audioWorklet]
expected: FAIL

@@ -38,9 +35,6 @@
[BaseAudioContext interface: operation createIIRFilter([object Object\], [object Object\])]
expected: FAIL

[BaseAudioContext interface: operation createPanner()]
expected: FAIL

[BaseAudioContext interface: operation createPeriodicWave([object Object\], [object Object\], PeriodicWaveConstraints)]
expected: FAIL

@@ -98,9 +92,6 @@
[AudioContext interface: context must inherit property "createMediaStreamDestination()" with the proper type]
expected: FAIL

[BaseAudioContext interface: context must inherit property "listener" with the proper type]
expected: FAIL

[BaseAudioContext interface: context must inherit property "audioWorklet" with the proper type]
expected: FAIL

@@ -143,9 +134,6 @@
[BaseAudioContext interface: calling createIIRFilter([object Object\], [object Object\]) on context with too few arguments must throw TypeError]
expected: FAIL

[BaseAudioContext interface: context must inherit property "createPanner()" with the proper type]
expected: FAIL

[BaseAudioContext interface: context must inherit property "createPeriodicWave([object Object\], [object Object\], PeriodicWaveConstraints)" with the proper type]
expected: FAIL

@@ -179,9 +167,6 @@
[OfflineAudioContext interface: calling suspend(double) on new OfflineAudioContext(1, 1, sample_rate) with too few arguments must throw TypeError]
expected: FAIL

[BaseAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "listener" with the proper type]
expected: FAIL

[BaseAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "audioWorklet" with the proper type]
expected: FAIL

@@ -224,9 +209,6 @@
[BaseAudioContext interface: calling createIIRFilter([object Object\], [object Object\]) on new OfflineAudioContext(1, 1, sample_rate) with too few arguments must throw TypeError]
expected: FAIL

[BaseAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "createPanner()" with the proper type]
expected: FAIL

[BaseAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "createPeriodicWave([object Object\], [object Object\], PeriodicWaveConstraints)" with the proper type]
expected: FAIL

@@ -416,90 +398,12 @@
[AudioNode interface: new AnalyserNode(context) must inherit property "channelInterpretation" with the proper type]
expected: FAIL

[AudioListener interface: existence and properties of interface object]
expected: FAIL

[AudioListener interface object length]
expected: FAIL

[AudioListener interface object name]
expected: FAIL

[AudioListener interface: existence and properties of interface prototype object]
expected: FAIL

[AudioListener interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
[AudioListener interface: existence and properties of interface prototype object's @@unscopables property]
expected: FAIL

[AudioListener interface: attribute positionX]
expected: FAIL

[AudioListener interface: attribute positionY]
expected: FAIL

[AudioListener interface: attribute positionZ]
expected: FAIL

[AudioListener interface: attribute forwardX]
expected: FAIL

[AudioListener interface: attribute forwardY]
expected: FAIL

[AudioListener interface: attribute forwardZ]
expected: FAIL

[AudioListener interface: attribute upX]
expected: FAIL

[AudioListener interface: attribute upY]
expected: FAIL

[AudioListener interface: attribute upZ]
expected: FAIL

[AudioListener interface: operation setPosition(float, float, float)]
expected: FAIL

[AudioListener interface: operation setOrientation(float, float, float, float, float, float)]
expected: FAIL

[AudioListener must be primary interface of context.listener]
expected: FAIL

[Stringification of context.listener]
expected: FAIL

[AudioListener interface: context.listener must inherit property "positionX" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "positionY" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "positionZ" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "forwardX" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "forwardY" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "forwardZ" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "upX" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "upY" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "upZ" with the proper type]
expected: FAIL

[AudioListener interface: context.listener must inherit property "setPosition(float, float, float)" with the proper type]
expected: FAIL

@@ -1673,201 +1577,6 @@
[OscillatorNode interface: calling setPeriodicWave(PeriodicWave) on new OscillatorNode(context) with too few arguments must throw TypeError]
expected: FAIL

[PannerNode interface: existence and properties of interface object]
expected: FAIL

[PannerNode interface object length]
expected: FAIL

[PannerNode interface object name]
expected: FAIL

[PannerNode interface: existence and properties of interface prototype object]
expected: FAIL

[PannerNode interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
[PannerNode interface: existence and properties of interface prototype object's @@unscopables property]
expected: FAIL

[PannerNode interface: attribute panningModel]
expected: FAIL

[PannerNode interface: attribute positionX]
expected: FAIL

[PannerNode interface: attribute positionY]
expected: FAIL

[PannerNode interface: attribute positionZ]
expected: FAIL

[PannerNode interface: attribute orientationX]
expected: FAIL

[PannerNode interface: attribute orientationY]
expected: FAIL

[PannerNode interface: attribute orientationZ]
expected: FAIL

[PannerNode interface: attribute distanceModel]
expected: FAIL

[PannerNode interface: attribute refDistance]
expected: FAIL

[PannerNode interface: attribute maxDistance]
expected: FAIL

[PannerNode interface: attribute rolloffFactor]
expected: FAIL

[PannerNode interface: attribute coneInnerAngle]
expected: FAIL

[PannerNode interface: attribute coneOuterAngle]
expected: FAIL

[PannerNode interface: attribute coneOuterGain]
expected: FAIL

[PannerNode interface: operation setPosition(float, float, float)]
expected: FAIL

[PannerNode interface: operation setOrientation(float, float, float)]
expected: FAIL

[PannerNode must be primary interface of new PannerNode(context)]
expected: FAIL

[Stringification of new PannerNode(context)]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "panningModel" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "positionX" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "positionY" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "positionZ" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "orientationX" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "orientationY" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "orientationZ" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "distanceModel" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "refDistance" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "maxDistance" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "rolloffFactor" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "coneInnerAngle" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "coneOuterAngle" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "coneOuterGain" with the proper type]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "setPosition(float, float, float)" with the proper type]
expected: FAIL

[PannerNode interface: calling setPosition(float, float, float) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[PannerNode interface: new PannerNode(context) must inherit property "setOrientation(float, float, float)" with the proper type]
expected: FAIL

[PannerNode interface: calling setOrientation(float, float, float) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "connect(AudioNode, unsigned long, unsigned long)" with the proper type]
expected: FAIL

[AudioNode interface: calling connect(AudioNode, unsigned long, unsigned long) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "connect(AudioParam, unsigned long)" with the proper type]
expected: FAIL

[AudioNode interface: calling connect(AudioParam, unsigned long) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect()" with the proper type]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect(unsigned long)" with the proper type]
expected: FAIL

[AudioNode interface: calling disconnect(unsigned long) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect(AudioNode)" with the proper type]
expected: FAIL

[AudioNode interface: calling disconnect(AudioNode) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect(AudioNode, unsigned long)" with the proper type]
expected: FAIL

[AudioNode interface: calling disconnect(AudioNode, unsigned long) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect(AudioNode, unsigned long, unsigned long)" with the proper type]
expected: FAIL

[AudioNode interface: calling disconnect(AudioNode, unsigned long, unsigned long) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect(AudioParam)" with the proper type]
expected: FAIL

[AudioNode interface: calling disconnect(AudioParam) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "disconnect(AudioParam, unsigned long)" with the proper type]
expected: FAIL

[AudioNode interface: calling disconnect(AudioParam, unsigned long) on new PannerNode(context) with too few arguments must throw TypeError]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "context" with the proper type]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "numberOfInputs" with the proper type]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "numberOfOutputs" with the proper type]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "channelCount" with the proper type]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "channelCountMode" with the proper type]
expected: FAIL

[AudioNode interface: new PannerNode(context) must inherit property "channelInterpretation" with the proper type]
expected: FAIL

[PeriodicWave interface: existence and properties of interface object]
expected: FAIL

5 ...e-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html.ini
View file
Open in desktop
@@ -1,2 +1,5 @@
[audiobuffersource-multi-channels.html]
expected: CRASH
expected: TIMEOUT
[X Rendered audio for channel 0 does not equal [0,0.19242584705352783,0.3714718818664551,0.5250332355499268,0.6435103416442871,0.7207010388374329,0.7542802691459656,0.7458723187446594,0.7007185816764832,0.6269197463989258,0.5344454050064087,0.4339446425437927,0.33560463786125183,0.24808235466480255,0.17771567404270172,0.12810270488262177...\] with an element-wise tolerance of {"absoluteThreshold":0.000030517578125,"relativeThreshold":0}.\n\tIndex\tActual\t\t\tExpected\t\tAbsError\t\tRelError\t\tTest threshold\n\t[1\]\t6.2648326158523560e-2\t1.9242584705352783e-1\t1.2977752089500427e-1\t6.7442873648311685e-1\t3.0517578125000000e-5\n\t[2\]\t1.2505052983760834e-1\t3.7147188186645508e-1\t2.4642135202884674e-1\t6.6336474995282613e-1\t3.0517578125000000e-5\n\t[3\]\t1.8696144223213196e-1\t5.2503323554992676e-1\t3.3807179331779480e-1\t6.4390551002679652e-1\t3.0517578125000000e-5\n\t[4\]\t2.4813784658908844e-1\t6.4351034164428711e-1\t3.9537249505519867e-1\t6.1439959775152853e-1\t3.0517578125000000e-5\n\t[5\]\t3.0833941698074341e-1\t7.2070103883743286e-1\t4.1236162185668945e-1\t5.7216737542361873e-1\t3.0517578125000000e-5\n\t...and 44074 more errors.\n\tMax AbsError of 8.6889546364545822e-1 at index of 129.\n\t[129\]\t9.7299009561538696e-1\t1.0409463196992874e-1\t8.6889546364545822e-1\t8.3471687944145678e+0\t3.0517578125000000e-5\n\tMax RelError of 1.2424206265621037e+5 at index of 1363.\n\t[1363\]\t-5.8316510915756226e-1\t4.6938193918322213e-6\t5.8316980297695409e-1\t1.2424206265621037e+5\t3.0517578125000000e-5\n]
expected: FAIL

13 tests/wpt/metadata/webaudio/the-audio-api/the-pannernode-interface/ctor-panner.html.ini
View file
Open in desktop
@@ -1,5 +1,4 @@
[ctor-panner.html]
expected: ERROR
[X context = new OfflineAudioContext(...) incorrectly threw ReferenceError: "OfflineAudioContext is not defined".]
expected: FAIL

@@ -9,3 +8,15 @@
[X node0 = new PannerNode(context) incorrectly threw TypeError: "window[name\] is not a constructor".]
expected: FAIL

[< [test AudioNodeOptions\] 2 out of 18 assertions were failed.]
expected: FAIL

[X new PannerNode(c, {"channelCount":0}) did not throw an exception.]
expected: FAIL

[# AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed.]
expected: FAIL

[X node6.channelInterpretation is not equal to discrete. Got speakers.]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.