New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some WebAudio WPTs #21506

Merged
merged 3 commits into from Sep 25, 2018

Conversation

Projects
6 participants
@ferjm
Member

ferjm commented Aug 24, 2018

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@ferjm ferjm requested a review from Manishearth Aug 24, 2018

@highfive

This comment has been minimized.

highfive commented Aug 24, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/audiobuffersourcenode.rs, components/script/dom/audioscheduledsourcenode.rs, components/script/dom/audiobuffer.rs
  • @KiChjang: components/script/dom/audiobuffersourcenode.rs, components/script/dom/audioscheduledsourcenode.rs, components/script/dom/audiobuffer.rs
@ferjm

This comment has been minimized.

Member

ferjm commented Aug 24, 2018

@ferjm

This comment has been minimized.

Member

ferjm commented Aug 24, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

⌛️ Trying commit 56bee81 with merge 81edb1c...

bors-servo added a commit that referenced this pull request Aug 24, 2018

Auto merge of #21506 - ferjm:webaudio.wpts, r=<try>
Fix some WebAudio WPTs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21506)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@Manishearth

This comment has been minimized.

Member

Manishearth commented Aug 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

📌 Commit 56bee81 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

⌛️ Testing commit 56bee81 with merge 9b46b24...

bors-servo added a commit that referenced this pull request Aug 24, 2018

Auto merge of #21506 - ferjm:webaudio.wpts, r=Manishearth
Fix some WebAudio WPTs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21506)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

💔 Test failed - mac-rel-wpt4

@ferjm

This comment has been minimized.

Member

ferjm commented Aug 24, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

⌛️ Testing commit 56bee81 with merge f3f7b56...

bors-servo added a commit that referenced this pull request Aug 24, 2018

Auto merge of #21506 - ferjm:webaudio.wpts, r=Manishearth
Fix some WebAudio WPTs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21506)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

💔 Test failed - mac-rel-css2

@Manishearth

This comment has been minimized.

Member

Manishearth commented Aug 24, 2018

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 24, 2018

✌️ @ferjm can now approve this pull request

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 25, 2018

☔️ The latest upstream changes (presumably #21502) made this pull request unmergeable. Please resolve the merge conflicts.

@ferjm

This comment has been minimized.

Member

ferjm commented Sep 24, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 24, 2018

⌛️ Trying commit cb14e02 with merge 3947346...

bors-servo added a commit that referenced this pull request Sep 24, 2018

Auto merge of #21506 - ferjm:webaudio.wpts, r=<try>
Fix some WebAudio WPTs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21506)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 24, 2018

💔 Test failed - linux-rel-css

@CYBAI

This comment has been minimized.

Collaborator

CYBAI commented Sep 24, 2018

Looks unrelated:

{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_webgl/conformance/extensions/ext-shader-texture-lod.html", "line": 140277, "action": "test_result", "expected": "OK"}

@ferjm ferjm force-pushed the ferjm:webaudio.wpts branch from cb14e02 to c170584 Sep 25, 2018

@ferjm

This comment has been minimized.

Member

ferjm commented Sep 25, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

⌛️ Trying commit c170584 with merge b7fbc0a...

bors-servo added a commit that referenced this pull request Sep 25, 2018

Auto merge of #21506 - ferjm:webaudio.wpts, r=<try>
Fix some WebAudio WPTs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21506)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@ferjm

This comment has been minimized.

Member

ferjm commented Sep 25, 2018

I only rebased and regenerated the test expectations, so I am carrying over Manish's r+ from #21506 (comment)

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

📌 Commit c170584 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

⌛️ Testing commit c170584 with merge 9ee8890...

bors-servo added a commit that referenced this pull request Sep 25, 2018

Auto merge of #21506 - ferjm:webaudio.wpts, r=Manishearth
Fix some WebAudio WPTs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21506)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

@bors-servo bors-servo merged commit c170584 into servo:master Sep 25, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ferjm ferjm added this to Done in WebAudio Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment