Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindgen to 0.39.0 #21516

Merged
merged 1 commit into from Aug 25, 2018
Merged

Update bindgen to 0.39.0 #21516

merged 1 commit into from Aug 25, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 24, 2018 •
edited

This fixes a build error for i686-linux-android with some versions of libclang:

error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error

This change is Reviewable
@SimonSapin
Update bindgen to 0.39.0
Loading status checks…
bcc1b25 
This fixes a build error for i686-linux-android with some versions of libclang:

```
error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error
```
@highfive
Copy link

highfive commented Aug 24, 2018

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Aug 24, 2018

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 24, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2018

📌 Commit bcc1b25 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned mbrubeck Aug 24, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2018

⌛ Testing commit bcc1b25 with merge 513dc45...
bors-servo added a commit that referenced this pull request Aug 24, 2018
@bors-servo
Auto merge of #21516 - servo:bindgenup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
513dc45 
Update bindgen to 0.39.0

This fixes a build error for i686-linux-android with some versions of libclang:

```rust
error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Aug 24, 2018

@bors-servo retry

  • oom
bors-servo added a commit that referenced this pull request Aug 24, 2018
@bors-servo
Auto merge of #21516 - servo:bindgenup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4a9169c 
Update bindgen to 0.39.0

This fixes a build error for i686-linux-android with some versions of libclang:

```rust
error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2018

⌛ Testing commit bcc1b25 with merge 4a9169c...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 24, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Aug 25, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

⌛ Testing commit bcc1b25 with merge f2306c8...
bors-servo added a commit that referenced this pull request Aug 25, 2018
@bors-servo
Auto merge of #21516 - servo:bindgenup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2306c8 
Update bindgen to 0.39.0

This fixes a build error for i686-linux-android with some versions of libclang:

```rust
error[E0560]: struct `generated::root::JS::Value` has no field named `__bindgen_align`sys
  --> /home/simon/projects/mozjs/src/jsval.rs:83:2
   |
83 |     __bindgen_align: [],
   |     ^^^^^^^^^^^^^^^ `generated::root::JS::Value` does not have this field
   |
   = note: available fields are: `data`

error: aborting due to previous error
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Aug 25, 2018

@bors-servo retry

  • oom
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Aug 25, 2018

@bors-servo retry

  • sccache problem
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Aug 25, 2018

@bors-servo retry

  • third try is the charm?
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 25, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing f2306c8 to master...
@bors-servo bors-servo merged commit bcc1b25 into master Aug 25, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: Pending (for pull_request.opened)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 3, 2018
@SimonSapin @emilio
Bug 1488172 - Update bindgen to 0.39.0. r=emilio
6223dfe 
This imports servo/servo#21516.
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Sep 3, 2018
@SimonSapin @emilio
Bug 1488172 - Update bindgen to 0.39.0. r=emilio
89d0e2e 
This imports servo/servo#21516.
@SimonSapin SimonSapin deleted the bindgenup branch Oct 10, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1488172 - Update bindgen to 0.39.0. r=emilio
4c75cb7 
This imports servo/servo#21516.

UltraBlame original commit: 6d06b38fcbe8feca23636d98513c7f80d48db0a5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1488172 - Update bindgen to 0.39.0. r=emilio
3dffdca 
This imports servo/servo#21516.

UltraBlame original commit: 6d06b38fcbe8feca23636d98513c7f80d48db0a5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1488172 - Update bindgen to 0.39.0. r=emilio
b90ce1e 
This imports servo/servo#21516.

UltraBlame original commit: 6d06b38fcbe8feca23636d98513c7f80d48db0a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @bors-servo @jdm @mbrubeck
You can’t perform that action at this time.