New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct currentSrc function #21521

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@nupurbaghel
Contributor

nupurbaghel commented Aug 25, 2018


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Aug 25, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlimageelement.rs
  • @KiChjang: components/script/dom/htmlimageelement.rs
@nupurbaghel

This comment has been minimized.

Contributor

nupurbaghel commented Aug 25, 2018

r? @jdm
But, there are some unexpected results too.

▶ Unexpected subtest result in /html/semantics/embedded-content/the-img-element/img.complete.html:
  │ FAIL [expected PASS] async src complete test
  │   → assert_equals: expected "/3.jpg" but got "/http://web-platform.test:8000/html/semantics/embedded-content/the-img-element/3.jpg"
  │ 
  │ @http://web-platform.test:8000/html/semantics/embedded-content/the-img-element/img.complete.html:42:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20
  └ Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1593:17

  ▶ Unexpected subtest result in /html/semantics/embedded-content/the-img-element/update-the-image-data/fail-to-resolve.html:
  │ FAIL [expected PASS] <img src="//[">
  │   → assert_equals: expected "//[" but got ""
  │ FAIL [expected PASS] <img srcset="//[" src="/images/red.png">
  │   → assert_equals: expected "//[" but got ""
  │ 
  │ onload/</<@http://web-platform.test:8000/html/semantics/embedded-content/the-img-element/update-the-image-data/fail-to-resolve.html:20:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20
  │ test@http://web-platform.test:8000/resources/testharness.js:544:9
  │ onload/<@http://web-platform.test:8000/html/semantics/embedded-content/the-img-element/update-the-image-data/fail-to-resolve.html:19:5
  └ onload@http://web-platform.test:8000/html/semantics/embedded-content/the-img-element/update-the-image-data/fail-to-resolve.html:18:3
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Aug 27, 2018

☔️ The latest upstream changes (presumably #21526) made this pull request unmergeable. Please resolve the merge conflicts.

@nupurbaghel nupurbaghel force-pushed the nupurbaghel:current_src branch from 5b7d69d to 5b57e1f Aug 28, 2018

@nupurbaghel

This comment has been minimized.

Contributor

nupurbaghel commented Aug 28, 2018

Trying to reopen to enable appveyor to rebuild.

@nupurbaghel nupurbaghel referenced this pull request Aug 28, 2018

Merged

correct currentSrc function #21533

3 of 4 tasks complete

bors-servo added a commit that referenced this pull request Sep 1, 2018

Auto merge of #21533 - nupurbaghel:current_src, r=jdm
correct currentSrc function

<!-- Please describe your changes on the following line: -->

---
(recreating PR which got closed earlier #21521)
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21533)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment