Some more drive-by WebGL fixes and cleanups #21523

nox · 2018-08-25T17:52:55Z

This change is

highfive · 2018-08-25T17:52:59Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl
@jgraham: tests/wpt/webgl/meta/conformance/rendering/preservedrawingbuffer-leak.html.ini, tests/wpt/webgl/meta/conformance/renderbuffers/framebuffer-state-restoration.html.ini, tests/wpt/webgl/meta/conformance/canvas/to-data-url-test.html.ini, tests/wpt/webgl/meta/conformance/attribs/gl-vertex-attrib.html.ini, tests/wpt/webgl/meta/conformance/more/conformance/methods.html.ini and 43 more
@KiChjang: components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl

nox · 2018-08-25T17:53:10Z

@bors-servo try

bors-servo · 2018-08-25T17:53:15Z

⌛ Trying commit 26f90da with merge 0d45913...


        Auto merge of #21523 - servo:webgl, r=<try>

Some more drive-by WebGL fixes and cleanups

bors-servo · 2018-08-25T18:32:28Z

💔 Test failed - mac-rel-css1

nox · 2018-08-25T19:04:47Z

Disabled many more tests, notably everything related to texture sources that we don't support at all.

@bors-servo try

bors-servo · 2018-08-25T19:04:52Z

⌛ Trying commit eb20457 with merge 59f9b1d...


        Auto merge of #21523 - servo:webgl, r=<try>

Some more drive-by WebGL fixes and cleanups  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21523)

bors-servo · 2018-08-25T19:41:29Z

💔 Test failed - mac-rel-wpt2

nox · 2018-08-25T20:46:02Z

Only unrelated failures again.

avadacatavra · 2018-08-27T13:01:38Z

tests/wpt/webgl/meta/conformance/more/conformance/quickCheckAPI-S_V.html.ini

@@ -1,3 +1,2 @@
 [quickCheckAPI-S_V.html]
-  type: testharness
-  expected: CRASH
+  disabled: https://github.com/servo/servo/issues/10656


lgtm but @jdm should take a look at any disabled tests to be sure

avadacatavra · 2018-08-27T13:01:38Z

tests/wpt/webgl/meta/conformance/canvas/canvas-test.html.ini

-  expected: ERROR
-  [Overall test]
-    expected: NOTRUN
+  disabled: drawing webgl canvas in 2d canvas is not supported yet


can you put a link to the issue for implementing this?

avadacatavra · 2018-08-27T13:01:38Z

tests/wpt/webgl/meta/conformance2/query/__dir__.ini

@@ -0,0 +1 @@
+disabled: queries are not supported yet


can you put a link for this issue?

avadacatavra · 2018-08-27T13:01:38Z

tests/wpt/webgl/meta/conformance/textures/canvas/__dir__.ini

@@ -0,0 +1 @@
+disabled: canvas textures are not implemented yet


can you put a link for this issue?

I was actually completely wrong about this specific folder of tests.

avadacatavra · 2018-08-27T13:01:38Z

components/script/dom/webgl2renderingcontext.rs

@@ -242,12 +242,17 @@ impl WebGL2RenderingContextMethods for WebGL2RenderingContext {

    #[allow(unsafe_code)]


is this needed anymore?

Removed, good catch fam.

avadacatavra · 2018-08-27T13:01:38Z

components/script/dom/webglrenderingcontext.rs

@@ -1896,50 +1883,43 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {

    #[allow(unsafe_code)]


is this needed anymore

Removed, good catch fam.

nox

I still need to add a few issue links but it's gym time.

nox · 2018-08-27T15:57:10Z

components/script/dom/webgl2renderingcontext.rs

@@ -242,12 +242,17 @@ impl WebGL2RenderingContextMethods for WebGL2RenderingContext {

    #[allow(unsafe_code)]


Removed, good catch fam.

nox · 2018-08-27T15:57:10Z

components/script/dom/webglrenderingcontext.rs

@@ -1896,50 +1883,43 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {

    #[allow(unsafe_code)]


Removed, good catch fam.

nox · 2018-08-27T15:57:10Z

tests/wpt/webgl/meta/conformance/textures/canvas/__dir__.ini

@@ -0,0 +1 @@
+disabled: canvas textures are not implemented yet


I was actually completely wrong about this specific folder of tests.

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/textures/misc/tex-video-using-tex-unit-non-zero.html.ini

-
-  [Overall test]
-    expected: NOTRUN
+  disabled: video textures are not supported yet


file and link to issue

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/textures/misc/texture-corner-case-videos.html.ini

-  expected: TIMEOUT
-  [Overall test]
-    expected: NOTRUN
+  disabled: video textures are not supported yet


link to issue

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/textures/misc/texture-npot-video.html.ini

-  expected: TIMEOUT
-  [Overall test]
-    expected: NOTRUN
+  disabled: video textures are not supported yet


link to issue

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/textures/svg_image/__dir__.ini

@@ -0,0 +1 @@
+disabled: SVG support is not implemented yet


iirc we don't have plans to implement this right now, so if that's the case I don't see the need to file an issue for it

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/textures/video/__dir__.ini

@@ -0,0 +1 @@
+disabled: video textures are not implemented yet


link to issue

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/textures/webgl_canvas/__dir__.ini

@@ -0,0 +1 @@
+disabled: canvas textures are not implemented yet


file/link to issue

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/canvas/draw-static-webgl-to-multiple-canvas-test.html.ini

-  expected: ERROR
-  [Overall test]
-    expected: NOTRUN
+  disabled: drawing webgl canvas in 2d canvas is not supported yet


link to issue

avadacatavra · 2018-08-28T14:17:50Z

tests/wpt/webgl/meta/conformance/canvas/draw-webgl-to-canvas-test.html.ini

-  expected: ERROR
-  [Overall test]
-    expected: NOTRUN
+  disabled: drawing webgl canvas in 2d canvas is not supported yet


link to issue


        Clean up some WebGL expectations


        Remove obsolete patch

jdm · 2018-08-30T14:20:34Z

@bors-servo r=avadacatavra,jdm

bors-servo · 2018-08-30T14:20:34Z

📌 Commit 900a190 has been approved by avadacatavra,jdm

bors-servo · 2018-08-30T16:13:36Z

⌛ Testing commit 900a190 with merge 8af3bf2...


        Auto merge of #21523 - servo:webgl, r=avadacatavra,jdm

Some more drive-by WebGL fixes and cleanups  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21523)

bors-servo · 2018-08-30T16:13:42Z

💔 Test failed - linux-rel-css

jdm · 2018-08-30T16:18:14Z

@bors-servo retry

infra problems

bors-servo · 2018-08-30T16:23:33Z

⌛ Testing commit 900a190 with merge 6f81ed4...


        Auto merge of #21523 - servo:webgl, r=avadacatavra,jdm

Some more drive-by WebGL fixes and cleanups  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21523)

bors-servo · 2018-08-30T16:33:32Z

💔 Test failed - linux-dev

jdm · 2018-08-30T16:52:49Z

@bors-servo retry

busted build machine

bors-servo · 2018-08-30T17:04:22Z

⚡ Previous build results for android-x86, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3 are reusable. Rebuilding only android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev...

bors-servo · 2018-08-30T17:17:36Z

💔 Test failed - mac-rel-css1

jdm · 2018-08-30T17:29:51Z

@bors-servo retry

bors-servo · 2018-08-30T17:40:32Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4...

bors-servo · 2018-08-30T18:27:03Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: avadacatavra,jdm
Pushing 6f81ed4 to master...

highfive assigned jdm Aug 25, 2018

highfive added the S-awaiting-review label Aug 25, 2018

highfive added the S-tests-failed label Aug 25, 2018

nox force-pushed the webgl branch from 26f90da to eb20457 Aug 25, 2018

highfive removed the S-tests-failed label Aug 25, 2018

highfive added the S-tests-failed label Aug 25, 2018

nox force-pushed the webgl branch from eb20457 to 64e45ad Aug 25, 2018

highfive removed the S-tests-failed label Aug 25, 2018

avadacatavra requested changes Aug 27, 2018

View changes

nox force-pushed the webgl branch from 6a954ee to 8a171be Aug 27, 2018

nox reviewed Aug 27, 2018

View changes

nox force-pushed the webgl branch 4 times, most recently from 4f9868a to f1f87dd Aug 27, 2018

avadacatavra reviewed Aug 28, 2018

View changes

nox force-pushed the webgl branch 2 times, most recently from 6719b89 to 8c9f7ec Aug 28, 2018

nox added 2 commits Aug 25, 2018

Clean up some WebGL expectations

20dc32d

Remove obsolete patch

b1ce74c

highfive added S-awaiting-review and removed S-tests-failed labels Aug 30, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 30, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 30, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 30, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 30, 2018

highfive added the S-tests-failed label Aug 30, 2018

bors-servo mentioned this pull request Aug 30, 2018

Introduce task queues, and throttling performance timeline tasksource #21388

Merged

0 of 5 tasks complete

jdm mentioned this pull request Aug 30, 2018

Replace mpsc with crossbeam-channel #21325

Merged

saschanaz mentioned this pull request Aug 28, 2019

Support unions as distinguishing WebIDL parameter #20513

Open

		@@ -0,0 +1 @@
		disabled: canvas textures are not implemented yet

		@@ -242,12 +242,17 @@ impl WebGL2RenderingContextMethods for WebGL2RenderingContext {

		#[allow(unsafe_code)]

		@@ -1896,50 +1883,43 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {

		#[allow(unsafe_code)]

		@@ -0,0 +1 @@
		disabled: video textures are not implemented yet

servo / servo

Join GitHub today

Some more drive-by WebGL fixes and cleanups #21523

Some more drive-by WebGL fixes and cleanups #21523

Conversation

nox commented Aug 25, 2018 • edited by SimonSapin

highfive commented Aug 25, 2018

nox commented Aug 25, 2018

bors-servo commented Aug 25, 2018

bors-servo commented Aug 25, 2018

nox commented Aug 25, 2018

bors-servo commented Aug 25, 2018

bors-servo commented Aug 25, 2018

nox commented Aug 25, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nox left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdm commented Aug 30, 2018

bors-servo commented Aug 30, 2018

bors-servo commented Aug 30, 2018

bors-servo commented Aug 30, 2018

jdm commented Aug 30, 2018

bors-servo commented Aug 30, 2018

bors-servo commented Aug 30, 2018

jdm commented Aug 30, 2018

bors-servo commented Aug 30, 2018

bors-servo commented Aug 30, 2018

jdm commented Aug 30, 2018

bors-servo commented Aug 30, 2018

bors-servo commented Aug 30, 2018

nox commented Aug 25, 2018 •

edited by SimonSapin