Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multichannel decoded audio #21539

Merged
merged 3 commits into from Sep 11, 2018
Merged

Add support for multichannel decoded audio #21539

merged 3 commits into from Sep 11, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Aug 30, 2018 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Aug 30, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/baseaudiocontext.rs, components/script/dom/offlineaudiocontext.rs, components/script/dom/audiobuffer.rs
  • @KiChjang: components/script/dom/baseaudiocontext.rs, components/script/dom/offlineaudiocontext.rs, components/script/dom/audiobuffer.rs
@highfive
Copy link

highfive commented Aug 30, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm
Copy link
Member Author

ferjm commented Sep 4, 2018

This needs #21325 to fix servo tidy issues.
ferjm added 2 commits Aug 30, 2018
@ferjm
Add support for multichannel decoded audio
f423ede
@ferjm
Add tidy exceptions for crossbeam-*
Loading status checks…
7a09477
@ferjm ferjm force-pushed the ferjm:multichannel.audio.decoder branch from 78bbd8d to 7a09477 Sep 11, 2018
@ferjm
Copy link
Member Author

ferjm commented Sep 11, 2018

#21325 is taking longer than expected and it is blocking servo-media updates, so I added the tidy exceptions from that PR here, along with an extra exception to ipc-channel that can be removed once #21325 lands.
@ferjm
Copy link
Member Author

ferjm commented Sep 11, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

⌛ Trying commit 7a09477 with merge ee7d59a...
bors-servo added a commit that referenced this pull request Sep 11, 2018
@bors-servo
Auto merge of #21539 - ferjm:multichannel.audio.decoder, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee7d59a 
[WIP] Add support for multichannel decoded audio

- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

💔 Test failed - linux-rel-css
@ferjm
Update WPT
Loading status checks…
079b242
@ferjm ferjm changed the title [WIP] Add support for multichannel decoded audio Add support for multichannel decoded audio Sep 11, 2018
@ferjm
Copy link
Member Author

ferjm commented Sep 11, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

⌛ Trying commit 079b242 with merge 133a717...
bors-servo added a commit that referenced this pull request Sep 11, 2018
@bors-servo
Auto merge of #21539 - ferjm:multichannel.audio.decoder, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
133a717 
Add support for multichannel decoded audio

- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True
@Manishearth
Copy link
Member

Manishearth commented Sep 11, 2018

@bors-servo try- r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

📌 Commit 079b242 has been approved by Manishearth
@Manishearth Manishearth mentioned this pull request Sep 11, 2018
Merged
@ferjm ferjm mentioned this pull request Sep 11, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

⌛ Testing commit 079b242 with merge 7a36161...
bors-servo added a commit that referenced this pull request Sep 11, 2018
@bors-servo
Auto merge of #21539 - ferjm:multichannel.audio.decoder, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a36161 
Add support for multichannel decoded audio

- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

💔 Test failed - mac-rel-wpt3
@ferjm
Copy link
Member Author

ferjm commented Sep 11, 2018

@bors-servo retry

I assume this is an intermittent network error:

fatal: unable to access 'https://github.com/servo/servo/': Server aborted the SSL handshake
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

⌛ Testing commit 079b242 with merge 049eb68...
bors-servo added a commit that referenced this pull request Sep 11, 2018
@bors-servo
Auto merge of #21539 - ferjm:multichannel.audio.decoder, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
049eb68 
Add support for multichannel decoded audio

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21539)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 049eb68 to master...
@bors-servo bors-servo mentioned this pull request Sep 11, 2018
Merged
0 of 5 tasks complete
@bors-servo bors-servo merged commit 079b242 into servo:master Sep 11, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 11, 2018
Merged
@ferjm ferjm deleted the ferjm:multichannel.audio.decoder branch Sep 11, 2018
@ferjm ferjm added this to Done in WebAudio Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
WebAudio
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ferjm @highfive @bors-servo @Manishearth @emilio
You can’t perform that action at this time.