Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora pkg names #21547

Merged
merged 2 commits into from Aug 31, 2018
Merged

Fedora pkg names #21547

merged 2 commits into from Aug 31, 2018
+4 −3

Conversation

@mathstuf
Copy link
Contributor

mathstuf commented Aug 30, 2018 •
edited by SimonSapin

Updates for more canonical names of Fedora Python packages in the docs.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

(Will let CI handle those two right now; working on building Servo for the first time myself at the moment.)

  • These changes do not require tests because they only update the README.md file

This change is Reviewable
@highfive
Copy link

highfive commented Aug 30, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.
@jdm
Copy link
Member

jdm commented Aug 30, 2018

@bors-servo r+
Thank you!
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

📌 Commit 7e2561c has been approved by jdm
@highfive highfive assigned jdm and unassigned avadacatavra Aug 30, 2018
@mathstuf
Copy link
Contributor Author

mathstuf commented Aug 30, 2018

Found another typo while building locally.
@mathstuf mathstuf force-pushed the mathstuf:fedora-pkg-names branch from 7e2561c to 38eb2ce Aug 30, 2018
@mathstuf
Copy link
Contributor Author

mathstuf commented Aug 30, 2018

And more…I'll wait for my build to finish I suppose :) .
@mathstuf
readme: remove a trailing whitespace
a0cd6f5
@jdm
Copy link
Member

jdm commented Aug 30, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

📌 Commit 38eb2ce has been approved by jdm
@mathstuf
readme: update Fedora package names
Loading status checks…
d567894 
Fedora has renamed `python` packages to be `python2` explicitly.
@mathstuf mathstuf force-pushed the mathstuf:fedora-pkg-names branch from 38eb2ce to d567894 Aug 30, 2018
@mathstuf
Copy link
Contributor Author

mathstuf commented Aug 30, 2018

Updated with two more gstreamer packages which are required and my build has now completed :) .
@jdm
Copy link
Member

jdm commented Aug 30, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

📌 Commit d567894 has been approved by jdm
@mathstuf
Copy link
Contributor Author

mathstuf commented Aug 30, 2018

CI failure looks to be due to a full disk on Travis (for those curious).
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

⌛ Testing commit d567894 with merge a9a9ebc...
bors-servo added a commit that referenced this pull request Aug 30, 2018
@bors-servo
Auto merge of #21547 - mathstuf:fedora-pkg-names, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a9a9ebc 
Fedora pkg names

Updates for more canonical names of Fedora Python packages in the docs.

---
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors

(Will let CI handle those two right now; working on building Servo for the first time myself at the moment.)

- [X] These changes do not require tests because they only update the `README.md` file

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21547)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - linux-rel-css
@mathstuf
Copy link
Contributor Author

mathstuf commented Aug 31, 2018

Hmm. Not sure what I can do with changes to a README to fix the test failures…
@ferjm
Copy link
Member

ferjm commented Aug 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit d567894 with merge 02b6155...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21547 - mathstuf:fedora-pkg-names, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
02b6155 
Fedora pkg names

Updates for more canonical names of Fedora Python packages in the docs.

---
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors

(Will let CI handle those two right now; working on building Servo for the first time myself at the moment.)

- [X] These changes do not require tests because they only update the `README.md` file

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21547)
<!-- Reviewable:end -->
@ferjm
Copy link
Member

ferjm commented Aug 31, 2018

Hmm. Not sure what I can do with changes to a README to fix the test failures…

@mathstuf these are just intermittent failures. You can ignore them.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 02b6155 to master...
@bors-servo bors-servo merged commit d567894 into servo:master Aug 31, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@mathstuf mathstuf deleted the mathstuf:fedora-pkg-names branch Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mathstuf @highfive @jdm @bors-servo @ferjm @avadacatavra
You can’t perform that action at this time.