Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format component compositing #21373 #21551

Merged
merged 1 commit into from Aug 31, 2018
Merged

Format component compositing #21373 #21551

merged 1 commit into from Aug 31, 2018

Conversation

@kingdido999
Copy link
Contributor

kingdido999 commented Aug 31, 2018 •
edited by SimonSapin 

rustfmt components/compositing/*.rs

This change is Reviewable
kingdido999
Format component compositing #21373
Loading status checks…
e4cd043
@highfive
Copy link

highfive commented Aug 31, 2018

Heads up! This PR modifies the following files:

  • @paulrouget: components/compositing/build.rs, components/compositing/compositor_thread.rs, components/compositing/touch.rs, components/compositing/gl.rs, components/compositing/compositor.rs
@jdm jdm mentioned this pull request Aug 31, 2018
Closed
53 of 53 tasks complete
@jdm
jdm approved these changes Aug 31, 2018
View changes
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

📌 Commit e4cd043 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Aug 31, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit e4cd043 with merge 59969dd...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21551 - kingdido999:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
59969dd 
Format component compositing #21373

<!-- Please describe your changes on the following line: -->

```bash
rustfmt components/compositing/*.rs
```

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit e4cd043 with merge de5597e...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21551 - kingdido999:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
de5597e 
Format component compositing #21373

<!-- Please describe your changes on the following line: -->

```bash
rustfmt components/compositing/*.rs
```

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - android-x86
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo retry

  • killed the offending emulator process
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit e4cd043 with merge ad2c3be...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21551 - kingdido999:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad2c3be 
Format component compositing #21373

<!-- Please describe your changes on the following line: -->

```bash
rustfmt components/compositing/*.rs
```

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing ad2c3be to master...
@bors-servo bors-servo merged commit e4cd043 into servo:master Aug 31, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kingdido999 @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.