Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify all WebGL test errors #21557

Merged
merged 2 commits into from Sep 1, 2018
Merged

Classify all WebGL test errors #21557

merged 2 commits into from Sep 1, 2018

Conversation

@nox
Copy link
Member

nox commented Aug 31, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Aug 31, 2018

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/webgl/meta/conformance/rendering/preservedrawingbuffer-leak.html.ini, tests/wpt/webgl/meta/conformance/textures/canvas/tex-2d-rgb-rgb-unsigned_short_5_6_5.html.ini, tests/wpt/webgl/meta/conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html.ini, tests/wpt/webgl/meta/conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_byte.html.ini, tests/wpt/webgl/meta/conformance/textures/webgl_canvas/tex-2d-rgba-rgba-unsigned_byte.html.ini and 17 more
@Manishearth
Copy link
Member

Manishearth commented Aug 31, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

📌 Commit 274bee9 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit 274bee9 with merge a601380...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21557 - servo:webgl, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a601380 
Classify all WebGL test errors

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21557)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - linux-rel-wpt
@nox
Add some bug links in WebGL 1.0 expectations
02bd263
@nox nox force-pushed the webgl branch from 274bee9 to adce28c Aug 31, 2018
@nox
Copy link
Member Author

nox commented Aug 31, 2018

Not sure how the expectations could be that wrong, I'm a bit confused.

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

📌 Commit adce28c has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit adce28c with merge 9e199f4...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21557 - servo:webgl, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e199f4 
Classify all WebGL test errors

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21557)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - linux-rel-css
@nox nox force-pushed the webgl branch from adce28c to 20d9050 Aug 31, 2018
@nox
Set dom.canvas-text.enabled for some WebGL tests
Loading status checks…
166ee7a
@nox nox force-pushed the webgl branch from 20d9050 to 166ee7a Aug 31, 2018
@nox
Copy link
Member Author

nox commented Aug 31, 2018

@bors-servo try-wpt
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Trying commit 166ee7a with merge ac8a943...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21557 - servo:webgl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac8a943 
Classify all WebGL test errors

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21557)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True
@nox
Copy link
Member Author

nox commented Aug 31, 2018

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

📌 Commit 166ee7a has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⌛ Testing commit 166ee7a with merge 577830d...
bors-servo added a commit that referenced this pull request Aug 31, 2018
@bors-servo
Auto merge of #21557 - servo:webgl, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
577830d 
Classify all WebGL test errors

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21557)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

💔 Test failed - mac-rel-wpt4
@jdm
Copy link
Member

jdm commented Aug 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 31, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 1, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 577830d to master...
@bors-servo bors-servo merged commit 166ee7a into master Sep 1, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @Manishearth @bors-servo @jdm
You can’t perform that action at this time.