Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChannelMergerNode #21591

Merged
merged 7 commits into from Sep 4, 2018
Merged

Implement ChannelMergerNode #21591

merged 7 commits into from Sep 4, 2018

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 3, 2018 •
edited by SimonSapin

partial #21558

Haven't yet tested, wanted to get this up as an example for #21558

This change is Reviewable
@Manishearth
Allow overriding GainNode's settings from the constructor
91b8cbe
@highfive
Copy link

highfive commented Sep 3, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/ChannelMergerNode.webidl, components/script/dom/channelmergernode.rs, components/script/dom/mod.rs, components/script/dom/audionode.rs, components/script/dom/gainnode.rs and 1 more
  • @KiChjang: components/script/dom/webidls/ChannelMergerNode.webidl, components/script/dom/channelmergernode.rs, components/script/dom/mod.rs, components/script/dom/audionode.rs, components/script/dom/gainnode.rs and 1 more
@highfive
Copy link

highfive commented Sep 3, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth Manishearth mentioned this pull request Sep 3, 2018
Closed
@Manishearth Manishearth force-pushed the Manishearth:channelmergernode branch 3 times, most recently from e5ff7b4 to acc76aa Sep 3, 2018
Manishearth added 6 commits Sep 3, 2018
@Manishearth
Add ChannelMergerNode
03d6fb1
@Manishearth
Update test expectations
0ac861c
@Manishearth
Throw on out-of-bounds channelCount in AudioNodes
28c2142
@Manishearth
Update test expectations
c76c6f3
@Manishearth
Regenerate test expectations
9a319f7 
Stuff was a bit buggy with the test expectations so I regenerated them.
Looks like some of the tests changed and this wasn't synced properly.
@Manishearth
Add createChannelMerger()
Loading status checks…
af5b1c4
@Manishearth Manishearth force-pushed the Manishearth:channelmergernode branch from acc76aa to af5b1c4 Sep 4, 2018
@ferjm
ferjm approved these changes Sep 4, 2018
View changes
Copy link
Member

ferjm left a comment

\o/ Nice work!
@ferjm
Copy link
Member

ferjm commented Sep 4, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

📌 Commit af5b1c4 has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

⌛ Testing commit af5b1c4 with merge 81f6ac8...
bors-servo added a commit that referenced this pull request Sep 4, 2018
@bors-servo
Auto merge of #21591 - Manishearth:channelmergernode, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
81f6ac8 
Implement ChannelMergerNode

partial #21558

Haven't yet tested, wanted to get this up as an example for #21558

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21591)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: ferjm
Pushing 81f6ac8 to master...
@bors-servo bors-servo mentioned this pull request Sep 4, 2018
Merged
3 of 3 tasks complete
@bors-servo bors-servo merged commit af5b1c4 into servo:master Sep 4, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@collares collares mentioned this pull request Jan 8, 2019
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this pull request Jan 10, 2019
@bors-servo
Auto merge of #22648 - collares:ChannelSplitterNode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d1d24a0 
Implement DOM APIs for ChannelSplitterNode

<!-- Please describe your changes on the following line: -->

Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix the second half of #21558

<!-- Either: -->
- [x] There are web-platform-tests tests for these changes
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Jan 11, 2019
@bors-servo
Auto merge of #22648 - collares:ChannelSplitterNode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ce2c933 
Implement DOM APIs for ChannelSplitterNode

<!-- Please describe your changes on the following line: -->

Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix the second half of #21558

<!-- Either: -->
- [x] There are web-platform-tests tests for these changes
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Jan 12, 2019
@bors-servo
Auto merge of #22648 - collares:ChannelSplitterNode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d4651cd 
Implement DOM APIs for ChannelSplitterNode

<!-- Please describe your changes on the following line: -->

Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix the second half of #21558

<!-- Either: -->
- [x] There are web-platform-tests tests for these changes
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Jan 12, 2019
@bors-servo
Auto merge of #22648 - collares:ChannelSplitterNode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
400e5ad 
Implement DOM APIs for ChannelSplitterNode

<!-- Please describe your changes on the following line: -->

Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix the second half of #21558

<!-- Either: -->
- [x] There are web-platform-tests tests for these changes
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Jan 12, 2019
@bors-servo
Auto merge of #22648 - collares:ChannelSplitterNode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c7cd1b8 
Implement DOM APIs for ChannelSplitterNode

<!-- Please describe your changes on the following line: -->

Based on #21591. Fixes #21558. I tried to update the expected results for WPT using "./mach update-wpt"; let me know if I got something wrong.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix the second half of #21558

<!-- Either: -->
- [x] There are web-platform-tests tests for these changes
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22648)
<!-- Reviewable:end -->
@Manishearth Manishearth deleted the Manishearth:channelmergernode branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees

@ferjm ferjm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @ferjm @bors-servo
You can’t perform that action at this time.