Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFormat components fallible and geometry #21373 #21598
Merged
Conversation
highfive
commented
Sep 4, 2018
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 4, 2018
Format components fallible and geometry #21373 ```bash rustfmt components/fallible/*.rs rustfmt components/geometry/*.rs ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21598) <!-- Reviewable:end -->
|
|
components/geometry/lib.rs
Outdated
| @@ -6,7 +6,8 @@ extern crate app_units; | |||
| extern crate euclid; | |||
| extern crate malloc_size_of; | |||
| extern crate style_traits; | |||
| #[macro_use] extern crate malloc_size_of_derive; | |||
| #[macro_use] | |||
| extern crate malloc_size_of_derive; | |||
This comment has been minimized.
This comment has been minimized.
jdm
Sep 4, 2018
Member
I'm not sure why this got past test-tidy previously, but please move this crate above style_traits.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 4, 2018
Format components fallible and geometry #21373 ```bash rustfmt components/fallible/*.rs rustfmt components/geometry/*.rs ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21598) <!-- Reviewable:end -->
|
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 5, 2018
This cherry-picks servo/servo#21598.
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Sep 5, 2018
This cherry-picks servo/servo#21598.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
This cherry-picks servo/servo#21598. UltraBlame original commit: 6609f1d4e2c85b5f287509d4f3ba478b074237df
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
This cherry-picks servo/servo#21598. UltraBlame original commit: 6609f1d4e2c85b5f287509d4f3ba478b074237df
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
This cherry-picks servo/servo#21598. UltraBlame original commit: 6609f1d4e2c85b5f287509d4f3ba478b074237df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kingdido999 commentedSep 4, 2018
•
edited by SimonSapin
This change is