Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set desc.obj in CodegenRust.py (fixes #11868) #21601

Merged
merged 1 commit into from Sep 4, 2018
Merged

Properly set desc.obj in CodegenRust.py (fixes #11868) #21601

merged 1 commit into from Sep 4, 2018

Conversation

@nox
Copy link
Member

nox commented Sep 4, 2018 •
edited by SimonSapin

This change is Reviewable
@nox
Properly set desc.obj in CodegenRust.py (fixes #11868)
Loading status checks…
baa9470
@highfive
Copy link

highfive commented Sep 4, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py
@highfive
Copy link

highfive commented Sep 4, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Sep 4, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

📌 Commit baa9470 has been approved by jdm
@highfive highfive assigned jdm and unassigned avadacatavra Sep 4, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

⌛ Testing commit baa9470 with merge 02c6896...
bors-servo added a commit that referenced this pull request Sep 4, 2018
@bors-servo
Auto merge of #21601 - servo:descobj, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
02c6896 
Properly set desc.obj in CodegenRust.py (fixes #11868)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21601)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Sep 4, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 02c6896 to master...
@bors-servo bors-servo merged commit baa9470 into master Sep 4, 2018
1 of 4 checks passed
1 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the descobj branch Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @avadacatavra
You can’t perform that action at this time.