Fix all AudioBuffer WPTs #21602

ferjm · 2018-09-04T14:31:02Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

This change is

highfive · 2018-09-04T14:31:06Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/audiobuffer.rs
@KiChjang: components/script/dom/audiobuffer.rs

ferjm · 2018-09-04T14:52:26Z


        Auto merge of #21602 - ferjm:audiobuffer.crash, r=<try>

Fix AudioBuffer crash - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21602)

bors-servo · 2018-09-04T14:52:34Z

⌛ Trying commit 54a7d4c with merge 94601ea...

ferjm · 2018-09-04T15:01:07Z

r? @Manishearth

bors-servo · 2018-09-04T15:12:41Z

💔 Test failed - linux-rel-css

ferjm · 2018-09-04T15:23:04Z

{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html", "line": 120970, "action": "test_result", "expected": "TIMEOUT"}
{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html", "line": 206207, "action": "test_result", "expected": "TIMEOUT"

Ugh

ferjm · 2018-09-04T15:29:47Z

If I run these two tests independently, I get the crashes. If I run them together via ./mach test-wpt tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface, I get timeouts.

ferjm · 2018-09-06T08:47:26Z

If I run these two tests independently, I get the crashes. If I run them together via ./mach test-wpt tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface, I get timeouts.

This is fun. I am getting different behaviors on OSX and Linux.

On OSX I get what I described above (timeouts when running all tests together). On Linux, what the try run reported (crashes).

ferjm · 2018-09-06T08:47:40Z

@bors-servo try=wpt

jdm · 2018-09-06T11:30:50Z

@bors-servo try=wpt

bors-servo · 2018-09-06T11:30:55Z

⌛ Trying commit a03de5d with merge 743a15b...


        Auto merge of #21602 - ferjm:audiobuffer.crash, r=<try>

Fix AudioBuffer crash - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21602)

bors-servo · 2018-09-06T11:58:30Z

💔 Test failed - linux-rel-wpt

ferjm · 2018-09-10T15:40:41Z

@bors-servo try=wpt

bors-servo · 2018-09-10T15:40:46Z

⌛ Trying commit 0e0e5a7 with merge 826b627...


        Auto merge of #21602 - ferjm:audiobuffer.crash, r=<try>

Fix AudioBuffer crash - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21602)

bors-servo · 2018-09-10T16:01:10Z

💔 Test failed - linux-rel-css

ferjm · 2018-09-10T16:10:02Z

Regarding #21602 (comment), I am trying to fix all these crashes, so we don't introduce intermittent TIMEOUT vs CRASH failures.

ferjm · 2018-09-18T20:49:34Z

@bors-servo try=wpt

bors-servo · 2018-09-18T20:49:39Z

⌛ Trying commit c91d697 with merge 54aa075...


        Auto merge of #21602 - ferjm:audiobuffer.crash, r=<try>

Fix all AudioBuffer WPTs - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21602)

bors-servo · 2018-09-18T21:15:59Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True


        Fix AudioBuffer crash. Do not modify number of channels while moving …

…from shared to js channels


        Throw when trying to copy AudioBuffer data from or to a SharedArrayBu…

…ffer


        Check AudioBuffer options constraints


        Implement AudioBufferSourceOptions.AudioBuffer and always keep servo …

…media audio buffer updated


        Apply start_in_channel to destination and not source during AudioBuff…

…er.CopyToChannel


        Throw IndexError if start_in_channel is equal to ArrayBuffer length


        Do not skip buffer update during copyToChannel


        Keep shared and js channels in sync


        Rustfmt audiobuffer.rs

ferjm · 2018-09-19T05:35:27Z

All AudioBuffer tests are passing now. I'll look at #21322 next. r? @Manishearth

Manishearth

r=me

should there be test expectation updates here?


        Update WPT

ferjm · 2018-09-19T07:34:01Z

should there be test expectation updates here?

Oh, I updated the expectation, but it seems that I discarded the commit while force pushing (that's one of the issues of working with two different machines...).

ferjm · 2018-09-19T08:07:00Z

@bors-servo r=Manishearth

bors-servo · 2018-09-19T08:07:01Z

📌 Commit 9b35633 has been approved by Manishearth

bors-servo · 2018-09-19T08:07:07Z

⌛ Testing commit 9b35633 with merge 0866dab...


        Auto merge of #21602 - ferjm:audiobuffer.crash, r=Manishearth

Fix all AudioBuffer WPTs - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21602)

bors-servo · 2018-09-19T09:04:54Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 0866dab to master...

highfive assigned emilio Sep 4, 2018

highfive added the S-awaiting-review label Sep 4, 2018

highfive assigned Manishearth and unassigned emilio Sep 4, 2018

highfive added the S-tests-failed label Sep 4, 2018

ferjm force-pushed the ferjm:audiobuffer.crash branch from 54a7d4c to a03de5d Sep 6, 2018

highfive removed the S-tests-failed label Sep 6, 2018

highfive added the S-tests-failed label Sep 6, 2018

ferjm force-pushed the ferjm:audiobuffer.crash branch from a03de5d to 0e0e5a7 Sep 10, 2018

highfive removed the S-tests-failed label Sep 10, 2018

highfive added the S-tests-failed label Sep 10, 2018

ferjm removed the S-needs-rebase label Sep 18, 2018

ferjm added 9 commits Sep 4, 2018

Fix AudioBuffer crash. Do not modify number of channels while moving …

e80ac00

…from shared to js channels

Throw when trying to copy AudioBuffer data from or to a SharedArrayBu…

b8ade93

…ffer

Check AudioBuffer options constraints

5307766

Implement AudioBufferSourceOptions.AudioBuffer and always keep servo …

e0e1f5f

…media audio buffer updated

Apply start_in_channel to destination and not source during AudioBuff…

10e8ab3

…er.CopyToChannel

Throw IndexError if start_in_channel is equal to ArrayBuffer length

a813892

Do not skip buffer update during copyToChannel

346d705

Keep shared and js channels in sync

138c739

Rustfmt audiobuffer.rs

Loading status checks…

4a927b5

ferjm force-pushed the ferjm:audiobuffer.crash branch from c91d697 to 4a927b5 Sep 19, 2018

Manishearth approved these changes Sep 19, 2018

View changes

Update WPT

Loading status checks…

9b35633

highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 19, 2018

highfive removed the S-awaiting-merge label Sep 19, 2018

ferjm deleted the ferjm:audiobuffer.crash branch Sep 19, 2018

ferjm added this to Done in WebAudio Nov 29, 2018

servo / servo

Fix all AudioBuffer WPTs #21602

Fix all AudioBuffer WPTs #21602

ferjm commented Sep 4, 2018 •

edited

highfive commented Sep 4, 2018

ferjm commented Sep 4, 2018

bors-servo commented Sep 4, 2018

ferjm commented Sep 4, 2018

bors-servo commented Sep 4, 2018

ferjm commented Sep 4, 2018

ferjm commented Sep 4, 2018

ferjm commented Sep 6, 2018

ferjm commented Sep 6, 2018

jdm commented Sep 6, 2018

bors-servo commented Sep 6, 2018

bors-servo commented Sep 6, 2018

ferjm commented Sep 10, 2018

bors-servo commented Sep 10, 2018

bors-servo commented Sep 10, 2018

ferjm commented Sep 10, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 18, 2018

bors-servo commented Sep 18, 2018

ferjm commented Sep 19, 2018 •

edited

Manishearth left a comment

ferjm commented Sep 19, 2018

ferjm commented Sep 19, 2018

bors-servo commented Sep 19, 2018

bors-servo commented Sep 19, 2018

bors-servo commented Sep 19, 2018

servo / servo

Join GitHub today

Fix all AudioBuffer WPTs #21602

Fix all AudioBuffer WPTs #21602

Conversation

ferjm commented Sep 4, 2018 • edited

highfive commented Sep 4, 2018

ferjm commented Sep 4, 2018

bors-servo commented Sep 4, 2018

ferjm commented Sep 4, 2018

bors-servo commented Sep 4, 2018

ferjm commented Sep 4, 2018

ferjm commented Sep 4, 2018

ferjm commented Sep 6, 2018

ferjm commented Sep 6, 2018

jdm commented Sep 6, 2018

bors-servo commented Sep 6, 2018

bors-servo commented Sep 6, 2018

ferjm commented Sep 10, 2018

bors-servo commented Sep 10, 2018

bors-servo commented Sep 10, 2018

ferjm commented Sep 10, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 18, 2018

bors-servo commented Sep 18, 2018

ferjm commented Sep 19, 2018 • edited

Manishearth left a comment

ferjm commented Sep 19, 2018

ferjm commented Sep 19, 2018

bors-servo commented Sep 19, 2018

bors-servo commented Sep 19, 2018

bors-servo commented Sep 19, 2018

ferjm commented Sep 4, 2018 •

edited

ferjm commented Sep 19, 2018 •

edited