Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFormat gfx platform #21373 #21610
Merged
Format gfx platform #21373 #21610
Conversation
highfive
commented
Sep 5, 2018
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 5, 2018
Format gfx platform #21373 ```bash rustfmt $(find components/gfx/platform -type f -name "*.rs") ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21610) <!-- Reviewable:end -->
|
|
you need a manual fix here. |
|
Perhaps try adding a newline above the two comment lines that were over-indented by rustfmt. |
|
Fixed. |
|
please squash commits |
| .field( | ||
| "bytes", | ||
| &self.bytes.as_ref().map(|b| format!("[{} bytes]", b.len())), | ||
| ).field("identifier", &self.identifier) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kingdido999
Sep 6, 2018
Author
Contributor
Looks like a similar issue has been reported: rust-lang/rustfmt#2932
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 7, 2018
Format gfx platform #21373 ```bash rustfmt $(find components/gfx/platform -type f -name "*.rs") ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21610) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kingdido999 commentedSep 5, 2018
•
edited by SimonSapin
rustfmt $(find components/gfx/platform -type f -name "*.rs")This change is