Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt layout_thread crate #21613

Merged
merged 1 commit into from Sep 5, 2018
Merged

Rustfmt layout_thread crate #21613

merged 1 commit into from Sep 5, 2018

Conversation

@pyfisch
Copy link
Contributor

pyfisch commented Sep 5, 2018

Part of #21373. Checked all changes looks good. 🎉 Manually removed two optional semicolons within unsafe so that it is formatted in one line.


This change is Reviewable

@highfive
Copy link

highfive commented Sep 5, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@pyfisch
Copy link
Contributor Author

pyfisch commented Sep 5, 2018

r? @jdm

@highfive highfive assigned jdm and unassigned Manishearth Sep 5, 2018
@Manishearth
Copy link
Member

Manishearth commented Sep 5, 2018

@bors-servo r+ rollup

wow I didn't realize how big this crate was

@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

📌 Commit 840e696 has been approved by Manishearth

@highfive highfive assigned Manishearth and unassigned jdm Sep 5, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

Testing commit 840e696 with merge d05cebd...

bors-servo added a commit that referenced this pull request Sep 5, 2018
Rustfmt layout_thread crate

Part of  #21373. Checked all changes looks good. 🎉 Manually removed two optional semicolons within unsafe so that it is formatted in one line.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21613)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

@bors-servo bors-servo merged commit 840e696 into servo:master Sep 5, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Sep 5, 2018
53 of 53 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.